Git Product home page Git Product logo

Comments (5)

Leeingnyo avatar Leeingnyo commented on May 18, 2024 1

Okay! I'll make a PR. I'm glad to contribute

from mango.

hkalexling avatar hkalexling commented on May 18, 2024 1

This is added in version v0.2.0. Thanks again for your contribution :D

from mango.

hkalexling avatar hkalexling commented on May 18, 2024

Hi, thanks for the feature request!

Most cbz files add leading zeros to the filenames (e.g., 001.jpg to 100.jpg) to make sure the images are displayed in the correct order. It looks like your zip/cbz file doesn't follow this convention.

I think what we can do is:

  1. Check whether the image filenames contain only numerical values.
  2. If so, check whether the filenames have leading zeros.
  3. If there's no leading zero, we parse the filenames and sort them by the numerical values.
  4. In other cases, we sort the images by filenames as strings.

This should be pretty easy to implement. I will work on this soon, and in the meantime feel free to let me know if you have any further suggestions on this issue.

from mango.

Leeingnyo avatar Leeingnyo commented on May 18, 2024

Oh yes. unfortunately my zip file doesn't have leading zeros...

I just made a code in the Crystal, which is implemented about method of above link
Here, https://repl.it/@Leeingnyo/ValidVigilantLinuxpc
Since I'm not used to the Crystal Language, this code should have some refactoring process.
or cause performance issue

I checked your comment lately... I would follow your opinion

from mango.

hkalexling avatar hkalexling commented on May 18, 2024

Your code looks good. If you want, feel free to submit a PR to the development branch v0.2.0. Don't worry; I would make some further modifications if there's any performance issue.

from mango.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.