Comments (5)
Okay! I'll make a PR. I'm glad to contribute
from mango.
This is added in version v0.2.0. Thanks again for your contribution :D
from mango.
Hi, thanks for the feature request!
Most cbz files add leading zeros to the filenames (e.g., 001.jpg
to 100.jpg
) to make sure the images are displayed in the correct order. It looks like your zip/cbz file doesn't follow this convention.
I think what we can do is:
- Check whether the image filenames contain only numerical values.
- If so, check whether the filenames have leading zeros.
- If there's no leading zero, we parse the filenames and sort them by the numerical values.
- In other cases, we sort the images by filenames as strings.
This should be pretty easy to implement. I will work on this soon, and in the meantime feel free to let me know if you have any further suggestions on this issue.
from mango.
Oh yes. unfortunately my zip file doesn't have leading zeros...
I just made a code in the Crystal, which is implemented about method of above link
Here, https://repl.it/@Leeingnyo/ValidVigilantLinuxpc
Since I'm not used to the Crystal Language, this code should have some refactoring process.
or cause performance issue
I checked your comment lately... I would follow your opinion
from mango.
Your code looks good. If you want, feel free to submit a PR to the development branch v0.2.0. Don't worry; I would make some further modifications if there's any performance issue.
from mango.
Related Issues (20)
- [Bug Report] "select all" button is not working correctly when filters are applied
- [Feature Request] allow update on website
- [Feature Request] More details on errors in "info" output
- [Bug Report] Unable to scan library. HOT 3
- [Feature Request] Add fit to width on continuous mode also
- [Bug Report] mango.db is not persistent in the Docker Image HOT 3
- Separate Read Progress for Each User HOT 2
- [Bug Report] Download Manager gives "Socket connection failed" on Safari using reverse proxy and live queue updates don't work
- library inaccessible after changing sort method from auto to date added HOT 1
- [Question] How should the library path be set in WSL2? HOT 1
- [Question] Issue Running docker-compose
- [Bug Report] Cannot authenticate via HTTP Basic Auth to access OPDS
- Armbian root password requirements are a joke[Question]
- [Bug Report/Build Failure/Feature Request] Upgrade to newer crystal version HOT 1
- [Bug Report] podman-compose up
- [Feature Request] Query the Metadata databases
- [Feature Request] Separate thumbnail storage
- [Feature Request] implement mangaword.bz ita
- [Question] - promoted as self-hosted solution but is dependant on external sources
- [Bug Report] stb_image_resize.h 404 error HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mango.