Git Product home page Git Product logo

Comments (13)

shelleyp avatar shelleyp commented on May 3, 2024
var = 2; 

as a program. That jars a bit.

from you-dont-know-js.

shelleyp avatar shelleyp commented on May 3, 2024

I can't help thinking you're really over-explaining scope with the compiler stuff. Do we really need to think like the Engine to understand it?

from you-dont-know-js.

shelleyp avatar shelleyp commented on May 3, 2024

I'm assuming you caught the missing image in the chapter 1 of the scope section.

from you-dont-know-js.

shelleyp avatar shelleyp commented on May 3, 2024

I don't want to be a broken record on the broken images, so will just note images not showing in chapter 2 of the closure section.

from you-dont-know-js.

shelleyp avatar shelleyp commented on May 3, 2024

Chapter 2 again, the note on accessing global object properties is abruptly introduced, and I don't think you defined what you mean by "shadowed" variables before using the term.

from you-dont-know-js.

shelleyp avatar shelleyp commented on May 3, 2024

Should mention how "with" is deprecated, and strict mode's impact on eval and variable scope. You mention this somewhat, but not explicitly.

And I'm not sure why you cover them and then tell people not to use them. Confusing.

from you-dont-know-js.

getify avatar getify commented on May 3, 2024

FYI: there are no images up on the repo yet. this is mostly a production issue, since images that are produced for a printed book require special care. i just haven't focused on that part of the workflow yet. Since I describe the images, the content should stand alone without them. If not, that's something to note in its own right. I may put images up on github at some point, not sure yet.

from you-dont-know-js.

shelleyp avatar shelleyp commented on May 3, 2024

Thanks, wasn't sure if we were supposed to report those or not.

from you-dont-know-js.

shelleyp avatar shelleyp commented on May 3, 2024

In chapter 3 of the closure and scope section you state "Some developers prefer a more explicit block-scoping, with dedicated blocks for scoping rather than implicitly hijacked block", but you don't give any reason why.

from you-dont-know-js.

shelleyp avatar shelleyp commented on May 3, 2024

Regarding let and const, is there a reference somewhere that covers browser support on these very new functionalities?

from you-dont-know-js.

shelleyp avatar shelleyp commented on May 3, 2024

Just wanted to note that Chapter 4 in the closure section, Hoisting, really pulls together your previous material. Well done.

from you-dont-know-js.

shelleyp avatar shelleyp commented on May 3, 2024

Chapter 5 on closure, not sure if you're concerned about JSLint giving a "don't make functions within a loop" warning with your anon function and timer example.

Also, am assuming you're giving folks a heads up on let elsewhere.

Otherwise, again pulls together the whole section. Good job.

from you-dont-know-js.

getify avatar getify commented on May 3, 2024

Thanks for all the great feedback. I've finished posting revisions that take your comments into account.

from you-dont-know-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.