Git Product home page Git Product logo

Comments (2)

pradyunsg avatar pradyunsg commented on June 29, 2024

Sounds good to me. Is there any use case which would be broken if your repository php-json-minify, is directly shifted to this repositories php branch?

from json.minify.

t1st3 avatar t1st3 commented on June 29, 2024

@pradyunsg

  1. being published on packagist requires composer.json to be adapted, since it references to the fork. Then, I don't know whether a non-default branch (here the php one) can be used on packagist, but here is some info about requiring non-deault branch: https://getcomposer.org/doc/05-repositories.md#vcs
  2. being a class rather than a function would be a breaking change. This could be circumvented by creating a class in a separate file, which would just include the original function. The namespace of the class would also need to be changed, since it also references to the fork.
  3. Since the namespace of the class should be modified, then, the test should be slightly modified too, in order to point to the newly-namespaced class.
  4. API doc should also be generated against the newly-namespaced class.

from json.minify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.