Comments (4)
rhukster
commented on September 21, 2024
I'm definitely up for improving the core shortcode plugin to make extending it even more powerful.
Without me having to dig in to deep, can you tell me what all the different Base classes are used for? I see you have an interface and some abstract classes, but you are inheriting the base in most cases? What about if you just had one base class with the key bits in it?
I'm all for simplifying if possible :)
Also, maybe you can fork the core plugin and submit a PR with your request. it's kinda hard to have to work out what's specific to your custom stuff and what would be considered appropriate for the core.
from grav-plugin-shortcode-core.
giansi
commented on September 21, 2024
Great. I will work on it!
from grav-plugin-shortcode-core.
rhukster
commented on September 21, 2024
Any progress on this PR? Going to do a release today, so will have to wait until the next one.
from grav-plugin-shortcode-core.
giansi
commented on September 21, 2024
Sorry no, it is not ready yet. We'll wait until the next one
from grav-plugin-shortcode-core.
Related Issues (20)
- CSS of shortcodes not loaded with twig, calling with markdown|shortcodes filter HOT 1
- Shortcode update creating copies of itself HOT 3
- Unexpected error message when updating v5.0.4 to v.5.0.5 HOT 6
- Shortcodes fail to render HOT 2
- Shortcodes don't work correctly with enabled Markdown Extra
- Accessing 'page' throws 404 error HOT 1
- Fontawesome icons are not displayed HOT 4
- Update Readme HOT 1
- Support 'subject' argument for safe-email shortcode
- Nested shortcodes broken in flex objects content HOT 5
- Unclear description of admin_pages_only option
- Twig variables not rendering inside html tags HOT 1
- Can't add assets after update HOT 4
- not possible to load JS assets in bottom group HOT 1
- Question: Autocomplete in Shortcode possible? HOT 1
- Update 4.1.6 to 4.2.3 breaks site HOT 10
- Shortcodes refer to wrong subpage when used in loop. HOT 3
- Shortcodes of subpages do not refer to the correct subpage.
- Assets not loaded when using shortcode only in Twig HOT 11
- Album icon shortcode
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from grav-plugin-shortcode-core.