No way to close a PR. about spr HOT 2 CLOSED

Nice, this would be a welcome addition indeed.

To be honest, I am no arc expert at all. I did use it every day at work, but I had my two to three things I did with it and don't know the details about all the other commands.

I think spr close would be a good name. "Revision" isn't GitHub lingo, and even when I still actively used Phabricator, I found the diff/revision nomenclature not well designed. Revision numbers began with a capital D (like D123), which meant that people said diff all the time, when they actually meant revision. Was all a bit muddled.

I think steps iii and iv.b don't need to be implemented. They are no local branches, just the references to remote branches (refs/remotes/origin/spr/...), and those will get removed by the "git push --delete ...".

Other than that: looks good!

from spr.

I was thinking about giving this a whirl. Assuming that's fine, I had a couple of questions before actually trying it:

• What would the command be called? Would it be spr close-revision to match arc? Or would it deviate from arc with something like spr close or another thing?

• Having never used arc in practice, I don't know all the ins and outs of what arc close-revision does. What all needs to happen in this command? It seems like:

  1. Close PR.
  2. Delete branch on GitHub.
  3. Delete branch in local repo.
  4. If it has a base branch:
     1. Delete base branch on GitHub.
     2. Delete base branch in local repo.

  Is that too much stuff? Is there something else I might've missed?

from spr.