Comments (2)
Hmm it might be because we've recently added pre-commit hooks that require an approval before it can be merged, as well as passing a build check
but my approval + build check is all against the parent diff instead of the main branch, so when spr land swaps it to be against the main branch, it fails the pre-commit hook until the newly build check that got kicked off finishes.
Any suggestions for how to best get around this? Is there a way for spr to bypass pre-commit hooks vs main, as long as they passed when it was against the parent diff?
from spr.
we ran into a similar issue recently, ours occured in a flow like this.
- commit A onto main
- spr diff
- commit B onto main
- spr diff
- B gets review with "changes requested"
- B requested changes get made
- B and A get re-ordered so that B can be merged first
- B gets accepted
- B cannot be landed because it claims it is not accepted
from spr.
Related Issues (20)
- Multiple stacks of work? HOT 1
- [question] Any way to support squash merging PR in GitHub UI and then update locally?
- [feature request] Show stack in PR
- [Critical Bug] Error when updating an existing PR HOT 4
- spr list (and land) PR statuses are always PENDING HOT 1
- Formula Name Conflict Between Two Projects
- Maintenance status HOT 1
- spr diff uses jujutsu to amend? HOT 4
- Changing Base Branche Dismisses the Reviewers' Approval
- `an unknown git error occurred; code=NotFound (-3)` HOT 1
- Please update the ring crate to 17.x
- Support specification of branch name in `spr diff` HOT 1
- Remove "Reviewers:" for `spr land` HOT 2
- Support for Bitbucket and others?
- invalid data in index - calculated checksum does not match expected; class=Index (10) HOT 1
- Use spr and bors together
- Spr doesn't recognize existing commits/PRs
- feat(cli): support `githubMasterBranch` from CLI
- [docs] Need clarification on how to insert a commit into the middle of an ongoing stacked PR review
- Documentation Webpage returning 404 from Github Pages HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spr.