Hi, it seems that woke version 0.18.1 has a bug handling git submodules. I think the p

Fix for this issue will be released in <a href="https://github.com/get-woke/woke/relea

I have a fix ready for this issue here: <a class="issue-link js-issue-link" data-error

woke check fails for git submodules about woke HOT 7 CLOSED

get-woke commented on May 28, 2024

woke check fails for git submodules

from woke.

Comments (7)

caitlinelfring commented on May 28, 2024 1

Fix for this issue will be released in v0.18.2

from woke.

fekete-robert commented on May 28, 2024 1

Thanks a lot!

from woke.

github-actions commented on May 28, 2024

👋 Thanks for submitting your first issue!

Please be sure to read and follow our Code of Conduct and Contributing guide.

⭐️ Is your org or open source project using woke? If so, we'd love for you to be included in the 'Who uses woke' list at https://github.com/get-woke/woke/blob/main/docs/about.md#who-uses-woke.

from woke.

caitlinelfring commented on May 28, 2024

Thanks for reporting! My guess this really has something to do with #117, which changed how ignores are handled. Can you do a few things for me?

Do you get the same behavior with v0.17.0? You can install it with curl -sSfL https://git.io/getwoke | bash -s -- -b ./ v0.17.0 and then run ./woke?
Would you mind sharing your .gitmodules or an example that produces the behavior so I can reproduce it?

Thanks!

from woke.

fekete-robert commented on May 28, 2024

Hi Caitlin, thanks for the reply.
woke version 0.17.1 works fine. Version 0.18.1 also finishes without errors when using the --no-ignores flag.
I'll create a test repo and get back to you.

from woke.

fekete-robert commented on May 28, 2024

git clone https://github.com/fekete-robert/woke-test.git --recursive

from woke.

caitlinelfring commented on May 28, 2024

I have a fix ready for this issue here: #194

from woke.

Recommend Projects