Git Product home page Git Product logo

Comments (3)

maread99 avatar maread99 commented on August 11, 2024

Hi @MBounouar, yes this change is intentional.

Here the minute is being passed as UTC midnight on the day of the calendar's first session, although the first minute covered by the calendar will be that session's first minute, (14:30 UTC). The exception's raised as the minute passed is earlier than the first minute covered by the calendar.

See the sessions and minutes tutorials for all things sessions and minutes in v4.

Cheers

from exchange_calendars.

MBounouar avatar MBounouar commented on August 11, 2024

Hi @maread99

If it was intentional, I will close the issue.

Though, I still would have expected that direction="next" (which is the default) wouldn't be so unforgiving in this particular case, and kept the old behavior.

Cheers,

from exchange_calendars.

maread99 avatar maread99 commented on August 11, 2024

Without being strict a user could, without realizing it, pass any minute before the calendar's first minute and wrongly, but reasonably, assume the calendar's first session is the corresponding session.

It makes no difference if the minute passed is 'just' before the first minute - without knowledge of the prior session's open/close it's not possible to know which session to assign a minute to (for example, for a 24h calendar the minute prior to the open should be assigned to the prior session).

from exchange_calendars.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.