Git Product home page Git Product logo

Comments (4)

georgewhewell avatar georgewhewell commented on August 26, 2024

I've thought a bit about this- mostly can't think of a nice way to expose options for user. I think it would be nice to allow different settings on battery and AC (like temp limit), so we 8 values in total to set. Maybe if we allow two values per option we can have --tdp-short-bat "15 30" --tdp-long-ac "20 40" etc. Any better suggestion? PR welcome if you want to attempt this yourself :)

from undervolt.

Oliph avatar Oliph commented on August 26, 2024

For the option (and could be applied for the temperature too) I have a suggestion, while not solving all issues, remove at least one option.

Rather than having one option for all, one option for AC and one option for battery why not just applying the temperature for ac and bat automatically. If the user also use a bat, the value is overridden when it is on battery. Then for instance for temperature.

Case 1: Uses of -t only

  • The temperature is applied for both AC and BAT (like now)

Case 2: Use of -t and -t-bat

  • the temperature are different for -t and -t-bat and use the values inserted. The -t is only used for AC

Case 3: Use of -t-bat only

  • the temperature remains unchanged for the AC (-15) and change for battery only.

For PR, I may take a look but I am far competent for that.

from undervolt.

georgewhewell avatar georgewhewell commented on August 26, 2024

@Oliph That's a good suggestion, thanks! I think I will have some time this weekend to look at this

from undervolt.

georgewhewell avatar georgewhewell commented on August 26, 2024

Closed via #93

from undervolt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.