Comments (8)
You can check the #34 Pull Request ;)
from konami-js.
I've merged #34. Give it another shot sometime @mably. Thanks for the update @FBerthelot!
from konami-js.
Thanks for the suggestion! Do you have any thoughts on how that might look? Do you have any examples of integrating the current version of konami-js in a SPA?
from konami-js.
We used it on one of our app to switch from test to prod environment ;)
It was used globally, changed a value in local storage and then reloaded the app (window.reload).
The problem is that it was being triggered by normal users navigating thru our app, a bit annoying ;)
So it could be interesting to be able to enable/disable it by adding a simple enable(bool)
method or eventually allow to reset the current Konami inputs when changing screen with a clearInput()
method for example.
from konami-js.
That's an interesting use case :). You're not the only company I've heard of using it that way! Though using it to switch from test to production sounds kind of scary. You're braver than me!
A feature like you're describing would be easy enough to add. But I wonder if it makes more sense to solve it within the context of the SPA itself, rather than add it as a feature to konami-js? There are a lot of factors to consider I know. What framework are you using, if I might ask?
from konami-js.
It's an Angular app. Actually we had to remove the Konami part once a few of our testers switched to dev env accidentally ;)
from konami-js.
Excellent! Will give it a try :)
from konami-js.
I will, thanks 😄
from konami-js.
Related Issues (20)
- Touch input is not properly validated HOT 4
- Usage of "const" keyword breaks older browsers and uglifyjs2 HOT 3
- Touch input broken HOT 2
- NPM package HOT 1
- The konami code of the demo redirects to a non-existing page HOT 1
- Add a release containing PR #42 HOT 1
- Roadmap of improvement HOT 3
- Add an ESLint configuration
- Drop Bower support
- Modernize code with ES6-features and functional aesthetic HOT 2
- Incorporate some kind of bundler support HOT 2
- New feature discussion HOT 2
- Create better examples and tutorials HOT 2
- Create Type Definitions for TS and/or Flow
- Version 2 api changing HOT 7
- Potential keyboard bug HOT 5
- Heard you on the podcast. Liked what I heard. Here's a cheat code... HOT 5
- Update documentation on the functions HOT 1
- Calling another Javascript file from a URL? HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from konami-js.