Git Product home page Git Product logo

Comments (10)

rkollataj avatar rkollataj commented on July 21, 2024 1

It looks like a problem with CANdb (3rdParty/CANdb submodule). I believe that below patch will solve the problem. I need to make sure with @btaczala (CANdb maintainer) if that's correct fix. @8bitgeek @SNL5943 Give it a try and let me know.

https://gist.github.com/rkollataj/28865272b1ed7791f8817484bad458c7

from candevstudio.

sangngocle avatar sangngocle commented on July 21, 2024

I have the same issue with J1939 ID, checking around in the code but stand still :(

from candevstudio.

rkollataj avatar rkollataj commented on July 21, 2024

@8bitgeek @SNL5943 Could you share DBC file you are loading?

from candevstudio.

8bitgeek avatar 8bitgeek commented on July 21, 2024

extended-ids.dbc.zip

from candevstudio.

btaczala avatar btaczala commented on July 21, 2024

@8bitgeek can I include dbc file into DBC repo (for testing purposes)?

from candevstudio.

sangngocle avatar sangngocle commented on July 21, 2024

@rkollataj : Yes, the issue is solved by your patch. Thanks!!

from candevstudio.

8bitgeek avatar 8bitgeek commented on July 21, 2024

The extended ids appear to be fixed.

However, now I have this issue where the CanSignalSender Value ranges are incorrect. Many of them read "min: 0 max: 0" which is incorrect.

candevstudio-wrong-ranges
candevstudio-wrong-ranges1

from candevstudio.

rkollataj avatar rkollataj commented on July 21, 2024

You're right. For CANParkBrakeStatus it should be min 0 and max 3. Was it like that before the patch or patch has broken this?

from candevstudio.

8bitgeek avatar 8bitgeek commented on July 21, 2024

I worked before. I appears to me that the patch broke this.

from candevstudio.

jogo- avatar jogo- commented on July 21, 2024

@8bitgeek @btaczala Have you tried with latest v1.2.2 ?

from candevstudio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.