IPT - Add zeros check for discrete vulnerability [risklib-related] about oq-platform HOT 5 CLOSED

This should not be done by the platform. We discussed this with Ben and Paolo in the past, the validation must be done by oq-lite and the platform should just call a validation API. This is a project for the next sprint, though.

from oq-platform.

I don't like the idea that the tool can generate files that can not be used directly in the engine for silly mistakes (plus, the check is very simple).

from oq-platform.

That's true, but it will become very hard to maintain a validation (which is sometime very complex) in two different places; the platform is also not well covered by tests and hard to test, so I agree with @micheles

In the platform we should put basic input constrains, like the "lowercase only" feature.

from oq-platform.

Me neither, this is why the project of validating the files with oq-lite has been approved, in theory even for this sprint. In practice we could not do it in time. It would be a waste of Ben's time doing the validation in a sub-optimal way.

from oq-platform.

This bug is totally related to risklib, and will be fixed in the 'oq-engine' repository.

from oq-platform.