Git Product home page Git Product logo

Comments (8)

stale avatar stale commented on May 28, 2024

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

from ansible-role-docker_arm.

stale avatar stale commented on May 28, 2024

This issue is no longer marked for closure.

from ansible-role-docker_arm.

geerlingguy avatar geerlingguy commented on May 28, 2024

I'd like to make sure the role works in check mode, so feel free to file a PR. Thanks!

from ansible-role-docker_arm.

callmeconnor avatar callmeconnor commented on May 28, 2024

OK, polishing it up now... will reply here once linting is OK. Sadly, I missed that your project lint's as it should, but initially didn't care too much...

from ansible-role-docker_arm.

callmeconnor avatar callmeconnor commented on May 28, 2024

OK, git groundwork done. Noticed you removed linting again, so also not relevant for my pullrequest anymore, I guess...

Glorious one liner pull request 19 is still existing ;) . Ready for you to review and merge: #19

from ansible-role-docker_arm.

callmeconnor avatar callmeconnor commented on May 28, 2024

hmm, not too deep into it, but:

Molecule default > converge
WARNING  An error occurred during the test sequence action: 'converge'. Cleaning up.

I may be missing something, Molecule may be right and I caused something not to comply any more...

from ansible-role-docker_arm.

callmeconnor avatar callmeconnor commented on May 28, 2024

Proof of work OK, did a check run, current output see below - tasks after "Check if Docker is already present" work as expected:

ansible-playbook raspi-docker.yml --check --connection=local
 [WARNING]: Found both group and host with same name: localhost

Executing playbook raspi-docker.yml

- Base Config for pi -
Gathering Facts...
Sunday 11 April 2021  14:45:00 +0200 (0:00:00.529)       0:00:00.529 ********** 
  localhost ok
Check if Docker is already present....
Sunday 11 April 2021  14:45:06 +0200 (0:00:05.915)       0:00:06.445 ********** 
  localhost ok | stdout: /usr/bin/docker
Download Docker install convenience script....
Sunday 11 April 2021  14:45:08 +0200 (0:00:01.880)       0:00:08.325 ********** 
Run Docker install convenience script....
Sunday 11 April 2021  14:45:08 +0200 (0:00:00.282)       0:00:08.608 ********** 
Make sure Docker CE is the version specified....
Sunday 11 April 2021  14:45:09 +0200 (0:00:00.283)       0:00:08.892 ********** 
  localhost done | stdout: Reading package lists...
Building dependency tree...
Reading state information...
Recommended packages:
  cgroupfs-mount | cgroup-lite libltdl7
The following packages will be DOWNGRADED:
  docker-ce
0 upgraded, 0 newly installed, 1 downgraded, 0 to remove and 0 not upgraded.
Inst docker-ce [5:20.10.5~3-0~raspbian-buster] (5:19.03.12~3-0~raspbian-buster Docker CE:buster [armhf])
Conf docker-ce (5:19.03.12~3-0~raspbian-buster Docker CE:buster [armhf])
 | stderr: W: --force-yes is deprecated, use one of the options starting with --allow instead.

Ensure containerd service dir exists....
Sunday 11 April 2021  14:45:19 +0200 (0:00:10.145)       0:00:19.037 ********** 
Add shim to ensure Docker can start in all environments....
Sunday 11 April 2021  14:45:19 +0200 (0:00:00.308)       0:00:19.346 ********** 
Reload systemd daemon if template is changed....
Sunday 11 April 2021  14:45:19 +0200 (0:00:00.324)       0:00:19.671 ********** 
Ensure Docker is started....
Sunday 11 April 2021  14:45:20 +0200 (0:00:00.313)       0:00:19.984 ********** 
  localhost ok
Install Docker Compose using Pip....
Sunday 11 April 2021  14:45:24 +0200 (0:00:03.843)       0:00:23.828 ********** 
Ensure docker users are added to the docker group....
Sunday 11 April 2021  14:45:24 +0200 (0:00:00.293)       0:00:24.122 ********** 
  localhost ok

- Play recap -
  localhost                  : ok=5    changed=1    unreachable=0    failed=0   
Sunday 11 April 2021  14:45:26 +0200 (0:00:02.506)       0:00:26.629 ********** 
=============================================================================== 
ansible-role-docker_arm : Make sure Docker CE is the version specified. ----------- 10.15s
Gathering Facts -------------------------------------------------------------------- 5.92s
ansible-role-docker_arm : Ensure Docker is started. -------------------------------- 3.84s
ansible-role-docker_arm : Ensure docker users are added to the docker group. ------- 2.51s
ansible-role-docker_arm : Check if Docker is already present. ---------------------- 1.88s
ansible-role-docker_arm : Add shim to ensure Docker can start in all environments. --- 0.32s
ansible-role-docker_arm : Reload systemd daemon if template is changed. ------------ 0.31s
ansible-role-docker_arm : Ensure containerd service dir exists. -------------------- 0.31s
ansible-role-docker_arm : Install Docker Compose using Pip. ------------------------ 0.29s
ansible-role-docker_arm : Run Docker install convenience script. ------------------- 0.28s
ansible-role-docker_arm : Download Docker install convenience script. -------------- 0.28s

P.S.: maybe "Make sure Docker CE is the version specified" could better work with dpkg instead of APT for a speedy result... or APT should get a flag set NOT to update caches instead... but that would be another issue.

from ansible-role-docker_arm.

geerlingguy avatar geerlingguy commented on May 28, 2024

Fixed via #19

from ansible-role-docker_arm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.