Comments (9)
fire
commented on August 12, 2024
Master should use 4.1 now.
from ecmascript.
fire
commented on August 12, 2024
I am testing builds on 4.1 Godot Engine https://github.com/V-Sekai/godot/tree/vsk-javascript-4.1
from ecmascript.
fire
commented on August 12, 2024
It fails to build on Linux etc.
modules/javascript/thirdparty/quickjs/quickjs_callable.cpp:30:9: error: member reference base type 'JSValue' (aka 'unsigned long long') is not a structure or union
js_func.u.ptr = p_function.javascript_object;
~~~~~~~^~
modules/javascript/thirdparty/quickjs/quickjs_callable.cpp:31:9: error: member reference base type 'JSValue' (aka 'unsigned long long') is not a structure or union
js_func.tag = JS_TAG_OBJECT;
~~~~~~~^~~~
modules/javascript/thirdparty/quickjs/quickjs_callable.cpp:41:7: error: member reference base type 'JSValue' (aka 'unsigned long long') is not a structure or union
temp.u.ptr = js_function.javascript_object;
~~~~^~
modules/javascript/thirdparty/quickjs/quickjs_callable.cpp:42:7: error: member reference base type 'JSValue' (aka 'unsigned long long') is not a structure or union
temp.tag = JS_TAG_OBJECT;
~~~~^~~~
modules/javascript/thirdparty/quickjs/quickjs_callable.cpp:50:9: error: member reference base type 'JSValue' (aka 'unsigned long long') is not a structure or union
js_func.u.ptr = js_function.javascript_object;
~~~~~~~^~
modules/javascript/thirdparty/quickjs/quickjs_callable.cpp:51:9: error: member reference base type 'JSValue' (aka 'unsigned long long') is not a structure or union
js_func.tag = JS_TAG_OBJECT;
~~~~~~~^~~~
modules/javascript/thirdparty/quickjs/quickjs_callable.cpp:58:9: error: member reference base type 'JSValue' (aka 'unsigned long long') is not a structure or union
js_func.u.ptr = js_function.javascript_object;
~~~~~~~^~
modules/javascript/thirdparty/quickjs/quickjs_callable.cpp:59:9: error: member reference base type 'JSValue' (aka 'unsigned long long') is not a structure or union
js_func.tag = JS_TAG_OBJECT;
~~~~~~~^~~~
modules/javascript/thirdparty/quickjs/quickjs_callable.cpp:72:9: error: member reference base type 'JSValue' (aka 'unsigned long long') is not a structure or union
js_func.tag = JS_TAG_OBJECT;
~~~~~~~^~~~
modules/javascript/thirdparty/quickjs/quickjs_callable.cpp:73:9: error: member reference base type 'JSValue' (aka 'unsigned long long') is not a structure or union
js_func.u.ptr = js_function.javascript_object;
~~~~~~~^~
10 errors generated.
scons: *** [modules/javascript/thirdparty/quickjs/quickjs_callable.android.template_release.arm32.o] Error 1
modules/javascript/thirdparty/quickjs/quickjs_debugger.cpp:82:24: error: out-of-line definition of 'connect' does not match any declaration in 'QuickJSDebugger'
Error QuickJSDebugger::connect(JSContext *ctx, const String &address) {
^~~~~~~```
from ecmascript.
nmerget
commented on August 12, 2024
Okay, I have several questions:
-
Why did you merge a branch with a failed pipeline into
master? The master branch should be protected by status checks which can't be bypassed to make sure that there is at least one valid branch. The PR should be reverted until the 4.1 is fixed. -
Before merging
4.1to master, we should open a new branch3.4. I don't know if someone is using this version for a "real" project, but we should make sure that we are still aligned with the major versions of godot. -
For https://github.com/V-Sekai/godot, we should make sure that we enable other builds for linux, which require some changes, but this should be another issue.
-
You changed/reverted a lot of the branch inside my fork. It's pretty hard to resolve what's going on now. Maybe we can rollback everything to make sure everything is tested?
from ecmascript.
fire
commented on August 12, 2024
- The failed pipeline isn't enabled until the ci can be merged. so we cannot see the effects until it is merged
- I'll do that immediately. ✅
- https://github.com/V-Sekai/godot - I had no way of testing this here because of (1), so I did it on the v-sekai orgination branch
- I'll do this in about an hour
a. copy the last 3.4 build to the branch 3.4 ✅
b. the last commit should be 1 commit on top of gd4 next
c. I'll rollback in one hour to this layout:
- previous master -> 3.4
- current master -> 4.1 (I will pretend 4.2 doesn't exist) ✅
- you can look at the gd4 for the commits. let me know if that is ok
from ecmascript.
fire
commented on August 12, 2024
To be clear. I'll rollback master to the last 3.4 in an hour.
from ecmascript.
fire
commented on August 12, 2024
@nmerget Visual Studio compiler diverged from the godot 3 version and the cicd breaks.
from ecmascript.
nmerget
commented on August 12, 2024
I reverted my initial branch to compare the differences between it and the current master. And I have some questions:
Why did you change the .github folder again? Basically dropped all my changes and keep the copy/paste from godotengine. Was this your purpose? Furthermore, the pipeline fails in master because of the wrong indent in this file.
In addition, I'm confused why you kept quickjs/quickjs_callable.cpp in this directory. It would make sense to me to:
- move it to
thirdparty/quickjsto have everything in one place - create a new directory
bindingsto with another directoryquickjsso we separatethirdpartyandbindings
--> I think the main task is to fix the pipeline(s) again and align all the branches, and we shouldn't copy/paste things from godotengine unless it makes sense
from ecmascript.
fire
commented on August 12, 2024
@nmerget I have been giving less effort to this project. @Geequlim I would suggest giving commit access to @nmerget as he's been doing a good job untangling this. Too many things going on.
You have my blessing to maintain the project.
from ecmascript.
Related Issues (20)
- CommonJS Module Support HOT 4
- Steps needs to run wasm HOT 1
- [Suggestion] Documentation and getting started tutorial HOT 8
- dev is ok , when i build get error below HOT 1
- Close issues that refer to Godot Engine 3 but don't exist in Godot Engine 4 HOT 1
- [4.1-v0.0.17] Signal arguments makes it crash HOT 4
- Get started page 404 HOT 2
- Configuring esbuild for bundling classes issue
- Missing template / examples for pre-release HOT 2
- Can I add this to an existing godot install? HOT 1
- .d.ts file has errors HOT 6
- Condition "!is_inside_tree()" is true. HOT 2
- Master build does not build with Godot HOT 2
- Unicode parsing error: Invalid unicode codepoint (fffd), cannot represent as ASCII/Latin-1 HOT 1
- Global pollution HOT 2
- Creating an object in js lost all built-in function links
- [BUMP] GodotJS addon: CSS integration
- 4.2+ support
- Is it dead? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ecmascript.