Karaoke mode doesn't match song position about spotifykaraoke HOT 3 CLOSED

Just an FYI, I updated the app today with a "relative scroll" feature, rather than a relative scroll. It also has a few other QoL changes that should improve the overall experience. Thanks again for your interest and suggestions 👍

from spotifykaraoke.

Awesome, thank you for this!

from spotifykaraoke.

Hi there Brady - thanks for filing this issue and for the suggestions, apologies for the super late reply. I finally got some time to take a look at this again. I had some trouble coming up with a good way of handling the lyric scrolling, but was never quite satisfied with it, but this seems like it may be a good solution. I did add a ton of padding to the end of the lyrics container as they were getting cut off pretty badly, but adjusting this is my next target.

I think this can help get this working properly:

• While a user is scrolling the lyrics manually, disable lyric scrollTop changing
• When a new song comes in, load in the lyrics and calculate the height of the container vs. the duration of the song (in seconds), divided that by the delay between song status pulls (2 seconds I believe) to figure out the per-second "adjustment" to make to the scrollTop position/
• Do away with adjusting the scroll position only after API calls, and replace it with a smooth scroll 👍

This will take some time (mostly in finding time), but if you have any more ideas for improvements, please don't hesitate to share, or submit a PR if you are so inclined :) Thanks again!

from spotifykaraoke.