Git Product home page Git Product logo

Comments (6)

vrijraj avatar vrijraj commented on June 18, 2024 1

New Features added

  1. Tooltips and alt text
  2. Can customize the icon from json file

and the component: https://github.com/gdg-x/aura/blob/master/src/components/home/whatWeDo.vue

from aura.

Splaktar avatar Splaktar commented on June 18, 2024 1

Looks good!

I know that this wasn't mentioned before, but it might be useful to optionally allow a url to be provided to link the icon to the docs page of the technology.

from aura.

vrijraj avatar vrijraj commented on June 18, 2024 1

URL added.
Need your review.
https://aura-client-master.firebaseapp.com/
and component: https://github.com/gdg-x/aura/blob/master/src/components/home/whatWeDo.vue

from aura.

Splaktar avatar Splaktar commented on June 18, 2024 1

Looks good, but I would call the argument here something like url or link rather than pic:

aura/src/components/home/whatWeDo.vue

Lines 72 to 74 in 82f8494

getImgUrl(pic) {
if(pic.length>0){
return require('@/assets/img/what-we-do/'+pic)

from aura.

vrijraj avatar vrijraj commented on June 18, 2024 1

I've made the changes. Have a look at that

https://github.com/gdg-x/aura/blob/master/src/components/home/whatWeDo.vue

from aura.

Splaktar avatar Splaktar commented on June 18, 2024

LGTM!

from aura.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.