Wrong indexOut in tx_out.csv? about rusty-blockparser HOT 9 CLOSED

EDIT: I believe the bug is in csvdump.rs, around line 100. Notice how right before for output in &tx.value.outputs there is let i = i as u32;. And this variable i is passed into output.as_csv(&txid_str, i), but it doesn't keep track of the index of the tx output - rather, it's the result of for (i, tx) in block.txs.iter().enumerate() {

from rusty-blockparser.

You are right, I mixed the index up somehow. Thanks for investigating, I will fix this as soon as I'm at home.

from rusty-blockparser.

PR #3 should fix your issue, could you run a quick test?

from rusty-blockparser.

I can't test it until later, but I just gave the PR a quick look and I don't see where/how txout_idx is incremented.

from rusty-blockparser.

Oh damn. I shouldnt write code in a hurry ;-). I will change it later and come back to you.

from rusty-blockparser.

fixed with 0.5.0

from rusty-blockparser.

Except it won't compile - see my comment on the commit :) and thanks!

from rusty-blockparser.

Did you pull the new changes? as_csv() expects an usize for the index: 0b102ed#diff-ecb7fa6af59617b0414f2244c129d48aR171

It's also a good idea to issue a cargo update because I've updated some dependencies

from rusty-blockparser.

Is this issue still relevant?

from rusty-blockparser.