Method annotations are not transformed about jarjar HOT 14 CLOSED

Can confirm this is an open issue with class-level annotations also.

This currently prevents applications that use Guice from using jarjar on the 
application.  After jarjar'ing the application, Guice complains that they 
annotaions are missing.

Funny story, I was using guice too.

I'm trying to Jar Jar the google collections API, most famous for it's
incompatibilities over the years.  

And I am having the seeing the same issue with the 1.0 rc2 version.

Has anyone found a workaround?

I hit the same problem, have done some investigation, and have an initial patch.

The issue seems to be in ASM, used by jarjar for the renaming of types.  It 
variously
doesn't attempt to rename annotation related types or calls what seems to be the
wrong method to do so (mapType calls that I think should be mapDesc).

I attach two patches - one for ASM that fixes the issue for me, and another for
jarjar with a test for annotation repackaging.  The test would probably now be 
better
rewritten as an ASM test.  I patched ASM from the 3.1 tag but it also applies 
cleanly
to trunk (not otherwise tested).

To test the patch you need to build and replace jarjar's 
lib/asm-commons-3.1.jar.

I guess the next step is to raise an ASM bug.  I'll leave that for the moment 
in case
someone here wants to pick that up.

I have submitted a bug for this to the asm issue tracker here -
http://forge.ow2.org/tracker/index.php?func=detail&aid=314481&group_id=23&atid=1
00023

([email protected]) commentor 5 - could you post your updated fixed copy of the 
jarjarlinks jar here?

Attached.  This is jarjar trunk r128 with asm-commons 3.1 with my patch.

I'm new to both jarjar and ASM so I'd advise waiting for some review before 
using it
for anything other than testing.

Thanks a lot. It seems to work for me.

Ok it seems asm framework has committed your patch.
http://forge.ow2.org/tracker/?func=detail&atid=100023&aid=314481&group_id=23

For the record the patch was committed to asm trunk in r1412.

ASM 3.3 has now been released, which includes the fix from above.

1.1 should fix this (by upgrading asm from 3.1 to 3.3.1).