Git Product home page Git Product logo

Comments (2)

bbbbbr avatar bbbbbr commented on May 27, 2024

Looks like it may be (mostly) working as designed right now, but in a way which doesn't meet the additional expectations of ZGB.

When -source_tileset is specified it only writes tile data/palettes/etc out if new entries are found which are not present in the source tileset.

However ZGB seems to expect:

  • A ___tiles_info {} struct to be generated regardless of whether any new tiles are found
  • And probably the same for ___tiles[], ____tile_pals[] and ___palettes[] regardless of whether they're empty or not

With the version in the develop branch (and CI) if you create a single novel tile in the map you can see that it begins to export some of the missing arrays.

It is probably not hard to force output of those entries for even if they are empty when -use_structs is present for ZGB. However:

  • It's not clear without testing whether empty arrays would be ok or might cause a crash
  • That still wouldn't include the source tileset data, so that would still have to get loaded. Did you envision having that data be included in the output, or manually loading it on your own from a separate file?

Going to @Zal0 into this since he may have some opinions about the right way to support this.

from gbdk-2020.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.