Comments (4)
Alright I figured out how to open and test a specific level, and it looks like the rebase solution is valid.
Maybe this should be changed to specify that work has been pushed and rebase isn't an option? It could even require you to push the changes.
from githug.
@FellowMD The solution ensures that revert has been used. I think simply stating that you should not use rebase because it has been pushed will be sufficient.
from githug.
The solution actually explicitly accepts either the revert option or the rebase option:
solution do
valid = false
valid = true if repo.commits.length > 3 &&
repo.commits[3].message == "First commit" &&
repo.commits[2].message == "Second commit" &&
repo.commits[1].message == "Bad commit" &&
repo.commits[0].message.split("\n").first == "Revert \"Bad commit\""
valid = true if repo.commits[1].message == "First commit" &&
repo.commits[0].message == "Second commit"
valid
end
Considering there are already a lot of rebase levels, would you want to maybe remove the rebase solution, and make the player push the revert solution to a remote (which already has Bad commit)? I'll make the changes if you'd want that
from githug.
@FellowMD That is a very good point, I obviously wasn't paying attention when I checked this morning!
Why don't we just remove the second check, so it is only valid if they have used revert
? What advantage would making the player push the solution offer?
from githug.
Related Issues (20)
- Level 10 wrong number off files to be committed
- Can I switch to a specific level? HOT 1
- Scoop安装失败 HOT 1
- GitHug gem on rubygems.org is extremely outdated!
- Several levels don't recognize default branch not named `master` HOT 1
- Level 28, behaving not as expected
- Stage 14 not accepting the answer even though it's presumably correct HOT 2
- Change delete branch hint
- Level 4 not working as expected in Ubuntu 18.04 HOT 4
- Support using GitHug in the classroom HOT 1
- DISCUSSION: New level-set branch based on Git Immersion by Jim Weirich HOT 1
- Enhance Dockerfile classroom functionality
- Potential issue in checkout_tag.rb (level 34)
- Issu in levels 4, 16 and so: what you should do HOT 3
- Problem in level 37
- Githug doesnt work HOT 3
- level 28 cannot pass HOT 2
- will there be an update to rubygem? HOT 10
- git switches branches but the directory remains the same
- trava_format,celulr
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from githug.