Comments (4)
You should add a license block to the top of each file. Other than that, looks
good.
r=me.
Original comment by [email protected]
on 26 Aug 2006 at 2:43
- Changed title: Review: import a few Java files
from google-breakpad.
Sorry, I send out files in a wrong directory. I made copyright changes in
another
working directory already. Now I re-attach the diff here. In this diff, I added
all
Java files under java/common/src/com/google/airbag/common, and a build.xml
script.
The code doesn't compile yet, because it depends on servlet api. A third-party
library will be checked in later.
I am curious what tools you used to do review. Is it hard?
Thanks.
Original comment by [email protected]
on 28 Aug 2006 at 5:49
Attachments:
from google-breakpad.
Original comment by [email protected]
on 29 Aug 2006 at 7:25
from google-breakpad.
Original comment by [email protected]
on 29 Aug 2006 at 8:45
- Changed state: Fixed
from google-breakpad.
Related Issues (20)
- ‘O_RDONLY’ was not declared in this scope HOT 2
- NetworkSourceLineResolverServer.SystemTest unit test fails/crashes on Mac OS X. HOT 2
- ContextDeathTest.X86BadFlags unit test fails on Mac OS X HOT 2
- Missing way to compile libbreakpad_client.a on Mac OS X HOT 3
- Crashed while reporting a crash in another app HOT 1
- dump_syms slow on Windows 64 bit binaries HOT 20
- bad x86 instructions cause null derefs in the disassembler HOT 1
- make check fails 1 test on ubuntu 10.04 64-bit HOT 1
- Breakpad test under x86_64 Linux doesn't show full trace HOT 3
- curl/types.h removed from libcurl >= 7.21.7 HOT 1
- google-breakpad doesn't build with gcc-4.6.0 HOT 1
- [client/mac] crash_report minidump symbolication tool no longer builds HOT 1
- Bad calls need to recover the previous frame at *%esp (x86), *%rsp (x86_64), probably other CPUs too HOT 2
- Breakpad.framework & Crash Report Sender doesn't pas Mac App Store validation prior to submission HOT 1
- MinGW support for the Windows client HOT 12
- Support for compiling without -DUNICODE
- Tiny bug in libdisasm HOT 1
- symupload takes to much time with big 64bits pdb HOT 1
- Exception Type: EXC_BAD_ACCESS (SIGBUS) Exception Codes: KERN_PROTECTION_FAILURE at 0x000000001a7294d0 Crashed Thread: 6 HOT 2
- dump_syms spews lots of warnings when processing clang-produced DWARF HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from google-breakpad.