Git Product home page Git Product logo

Comments (6)

gaurav-nelson avatar gaurav-nelson commented on June 8, 2024 2

Thanks @ruzickap @musicEnfanthen for your inputs. I'll add it as a variable.

from github-action-markdown-link-check.

miguelsorianod avatar miguelsorianod commented on June 8, 2024 2

Hi,

Is this still planned to be added?

We are trying to use this action and we want to exclude one of the directories in our project but due to not being able to specify exclusions this makes us need to explicitly define the files and directories we want to use to avoid the undesired directory. This is not ideal as if there are new files and directories that contain .md files in the future one needs to remember adding it to the list which is easy to forget.

I would suggest adding a parameter to ignore a set of files, and a parameter to ignore a set of directories recursively. This is similarly to what's been done for inclusions.

Thank you

from github-action-markdown-link-check.

gaurav-nelson avatar gaurav-nelson commented on June 8, 2024

Thanks @ruzickap yes it makes sense. I'll take this one next.

from github-action-markdown-link-check.

gaurav-nelson avatar gaurav-nelson commented on June 8, 2024

@ruzickap I've had some success with replacing find with fd.
fd allows an .fdignore file https://github.com/sharkdp/fd#excluding-specific-files-or-directories

What do you think about not adding another option to exclude files and folder, instead recommending users to create an ./.fdignore file to skip specific files and folders?

from github-action-markdown-link-check.

ruzickap avatar ruzickap commented on June 8, 2024

I'm not sure if it's good idea to add some files (.fdignore) into the repository only to exclude the files during tests.
I would prefer to have variable and optionally .fdignore to exclude files from being "tested".

Maybe others have different opinion about it...

from github-action-markdown-link-check.

musicEnfanthen avatar musicEnfanthen commented on June 8, 2024

I would second that @ruzickap . The approach with .fdignore could lead to conflicts if another action also uses fd but you want to ignore (or not) different paths. Excluded files should preferably be limited to the individual action.

from github-action-markdown-link-check.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.