Comments (15)
Upgrade guide here.
from gatsby.
am interested in working on this one. @KyleAMathews, looks like, for react-router, the files to edit are static-entry and web-entry. Is that right?
Also, do you want to wait until actual releases? or have an implementation that uses the rc1 of each?
from gatsby.
That'd be great! Yeah those two +
https://github.com/gatsbyjs/gatsby/blob/master/lib/isomorphic/create-routes.coffee
which
is where React Routes are actually created. Everything else should stay
the same. Feel free to convert things to ES6 if you'd like as you go.
Thanks! Looking forward to your PR.
Oh and on timing, let's wait to do an actual release when both of their
1.0s are released. Perhaps do our own rc release if they're taking their
times.
On Thu, Sep 17, 2015 at 10:23 AM Phlogistic Fugu [email protected]
wrote:
am interested in working on this one. @KyleAMathews
https://github.com/KyleAMathews, looks like, for react-router, the
files to edit are static-entry and web-entry. Is that right?Also, do you want to wait until actual releases? or have an implementation
that uses the rc1 of each?β
Reply to this email directly or view it on GitHub
#32 (comment).
from gatsby.
API shouldn't change while they move out from -rc, should they?
from gatsby.
Re: ES6 conversion
Thanks, yeah I prefer JS/ES6 to coffeescript actually, but didn't want to rock the boat unnecessarily.
Re: releases and rc1
Yep it wouldn't quite be right to have a "production" release that has "non-production" dependencies. How about a new branch: react-router-v1.0
for work on this until the official release?
from gatsby.
The API shouldn't change no. I'm more concerned about potential bugs. But also as far as Gatsby is concerned, users of gatsby are pretty insulated from both router and react so upgrading is more of a keeping up with times than any major improvements.
Well other than code splitting on routes. That'll be very nice as people start to build bigger sites on gatsby.
from gatsby.
There's an issue already btw for code splitting #10
Also @phlogisticfugu converting to ES6 is the plan so not at all boat rocking :) @gesposito has actually been converting the starter sites + wrapper components recently.
from gatsby.
Hey @KyleAMathews I can work on react router upgrade. Should I just send a PR?
from gatsby.
Thanks @knowbody!
from gatsby.
Yep sorry I didn't end up submitting a PR, things have gotten hectic so I haven't gotten to playing with this. glad to see you jumping in @knowbody !
from gatsby.
#111
I'm in the process of finalizing the complete upgrade which included ES6 as well as newest React-router & Babel 6 + other improvements
from gatsby.
@knowbody how close is RR 2.0 to landing?
from gatsby.
https://twitter.com/ryanflorence/status/681737658532364290
from gatsby.
https://github.com/rackt/react-router/blob/master/upgrade-guides/v2.0.0.md
from gatsby.
0.8 has React-Router 2.0 now π
from gatsby.
Related Issues (20)
- matchPath in createPage for dynamic path generation is not working with case sensitive urls.
- `key` props is omitted in Head API HOT 1
- "Either the current working directory does not contain a valid package.jsonβ¦" when running with Node.js 20 HOT 1
- Navigation is not responsive when upgrading from Gatsby v 4.24 to v 5.12 HOT 2
- useStaticQuery breaking in Production for some users v5 HOT 4
- GraphiQL White Screen of Death on Gatsby V5.11.0 HOT 34
- ERROR #98123 WEBPACK: Generating SSR bundle failed HOT 8
- Error: Generated engines use disallowed import "node:crypto". Only allowed imports are to Node.js builtin modules or engines internals. HOT 1
- Adding content in the contributing.md file HOT 1
- change "Twitter" to "X (Twitter)" in README.md in Support And also in docs/contributing/index.md HOT 1
- environment variables not needed by SSR/DSG are being embedded in data.mdb
- navigate to newer version of the docs when you click search result in old version HOT 5
- query with `headings` field causes gatsby-transformer-remark to be run multiple times
- Is Gatsby discontinued? Please upvote for clarification. HOT 12
- Building multiple page categories with MarkdownRemark fails
- Skip media from download, get URL in query only
- Outdated reference to Gatsby Cloud in documentation HOT 1
- While shadowing a css file from a gatsby theme the changes are reflected in netlify preview but not on deployment HOT 4
- Null-Byte (\0) in HTML output files
- Missing onError handler for invocation 'building-schema', error was 'Error: Cannot create as TypeComposer the following value: Date.' HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gatsby.