Git Product home page Git Product logo

Comments (15)

gesposito avatar gesposito commented on May 2, 2024

Upgrade guide here.

from gatsby.

phlogisticfugu avatar phlogisticfugu commented on May 2, 2024

am interested in working on this one. @KyleAMathews, looks like, for react-router, the files to edit are static-entry and web-entry. Is that right?

Also, do you want to wait until actual releases? or have an implementation that uses the rc1 of each?

from gatsby.

KyleAMathews avatar KyleAMathews commented on May 2, 2024

That'd be great! Yeah those two +
https://github.com/gatsbyjs/gatsby/blob/master/lib/isomorphic/create-routes.coffee
which
is where React Routes are actually created. Everything else should stay
the same. Feel free to convert things to ES6 if you'd like as you go.

Thanks! Looking forward to your PR.

Oh and on timing, let's wait to do an actual release when both of their
1.0s are released. Perhaps do our own rc release if they're taking their
times.

On Thu, Sep 17, 2015 at 10:23 AM Phlogistic Fugu [email protected]
wrote:

am interested in working on this one. @KyleAMathews
https://github.com/KyleAMathews, looks like, for react-router, the
files to edit are static-entry and web-entry. Is that right?

Also, do you want to wait until actual releases? or have an implementation
that uses the rc1 of each?

β€”
Reply to this email directly or view it on GitHub
#32 (comment).

from gatsby.

gesposito avatar gesposito commented on May 2, 2024

API shouldn't change while they move out from -rc, should they?

from gatsby.

phlogisticfugu avatar phlogisticfugu commented on May 2, 2024

Re: ES6 conversion
Thanks, yeah I prefer JS/ES6 to coffeescript actually, but didn't want to rock the boat unnecessarily.

Re: releases and rc1
Yep it wouldn't quite be right to have a "production" release that has "non-production" dependencies. How about a new branch: react-router-v1.0 for work on this until the official release?

from gatsby.

KyleAMathews avatar KyleAMathews commented on May 2, 2024

The API shouldn't change no. I'm more concerned about potential bugs. But also as far as Gatsby is concerned, users of gatsby are pretty insulated from both router and react so upgrading is more of a keeping up with times than any major improvements.

Well other than code splitting on routes. That'll be very nice as people start to build bigger sites on gatsby.

from gatsby.

KyleAMathews avatar KyleAMathews commented on May 2, 2024

There's an issue already btw for code splitting #10

Also @phlogisticfugu converting to ES6 is the plan so not at all boat rocking :) @gesposito has actually been converting the starter sites + wrapper components recently.

from gatsby.

knowbody avatar knowbody commented on May 2, 2024

Hey @KyleAMathews I can work on react router upgrade. Should I just send a PR?

from gatsby.

KyleAMathews avatar KyleAMathews commented on May 2, 2024

Thanks @knowbody!

from gatsby.

phlogisticfugu avatar phlogisticfugu commented on May 2, 2024

Yep sorry I didn't end up submitting a PR, things have gotten hectic so I haven't gotten to playing with this. glad to see you jumping in @knowbody !

from gatsby.

bartekus avatar bartekus commented on May 2, 2024

#111
I'm in the process of finalizing the complete upgrade which included ES6 as well as newest React-router & Babel 6 + other improvements

from gatsby.

KyleAMathews avatar KyleAMathews commented on May 2, 2024

@knowbody how close is RR 2.0 to landing?

from gatsby.

gesposito avatar gesposito commented on May 2, 2024

https://twitter.com/ryanflorence/status/681737658532364290

from gatsby.

gesposito avatar gesposito commented on May 2, 2024

https://github.com/rackt/react-router/blob/master/upgrade-guides/v2.0.0.md

from gatsby.

KyleAMathews avatar KyleAMathews commented on May 2, 2024

0.8 has React-Router 2.0 now πŸŽ‰

from gatsby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.