Git Product home page Git Product logo

Comments (5)

Cabbache avatar Cabbache commented on May 18, 2024

I've confirmed that it works when I make the name of the virtual interface shorter instead of 2 characters added to the original interface name.

from linux-router.

garywill avatar garywill commented on May 18, 2024

Hi, thank you for reporting the issue and sending PR!

I think it is better to defaultly name the new interface name after the original interface name.
People may create more than 1 virtual interface based on different wifi adapters simutaneously.

So adding an option to rename the new interface (e.g. --virt-name) would be better.
Also, the script should warn user if the original interface has a long name.

from linux-router.

garywill avatar garywill commented on May 18, 2024

I'm considering that

v_iface_name="$VIRT_PREFIX$i"

is not 100% preditable interface name

It is better to do it a preditable way

v_iface_name="$VIRT_NAME"

Let user decide the exact interface name

from linux-router.

Cabbache avatar Cabbache commented on May 18, 2024

Currently the alloc_new_vface_name function seems to increment $i until $VIRT_PREFIX$i is not the name of an existing interface. If we change it to v_iface_name="$VIRT_NAME", then should the script exit with an error if the interface already exists?

from linux-router.

garywill avatar garywill commented on May 18, 2024

from linux-router.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.