Git Product home page Git Product logo

Comments (3)

garybernhardt avatar garybernhardt commented on September 5, 2024

It's a nice detail, but does it really help with use, or is it just a cute distraction? I think it's probably the latter for me, since I can't remember ever taking an action based on it. But maybe other people do take action based on it? Or maybe it's useful to help new users understand what a fuzzy search is actually doing? What do you think? What's your motivation? (If it's simply that it's neat, I vote against, because I have to maintain this stuff. :)

Implementing it would probably require carrying the matching substring data along with a match. That probably means replacing the simple array of matching strings in the Search class with one Choice/Match/whatever object per string. That may have performance implications due to overhead of Ruby objects vs. simple strings (I'm just guessing, though; I haven't tried it.) There's a chance that these Choice/Match objects will be introduced anyway to facilitate some performance optimizations in #53.

from selecta.

wpp avatar wpp commented on September 5, 2024

Most of the time I don't even look at the selecta output. I just notice that something is popping up, type ahead and wait till my fail is showing up in vim. I was using command-t for a long time and can't even remember if had that feature. Personally it's not something I noticed or am missing.

from selecta.

Olivia5k avatar Olivia5k commented on September 5, 2024

My use-cases actually don't stretch much longer than the mistake one I already mentioned. I noted that when I typoed something I was expecting to see my mistake right away, and my brain did this quick segfault that it does when it expects something of a pattern and that didn't happen. :) It's not a big deal, and in the spirit of keeping things simple, I say this can be dropped!

Closing this.

from selecta.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.