Git Product home page Git Product logo

Comments (12)

Garux avatar Garux commented on September 26, 2024

It applies common/nodraw to nodraw-transparent and common/nodrawnonsolid to nodraw-transparent-nonsolid, so former is expected to be solid.

from netradiant-custom.

Aciz avatar Aciz commented on September 26, 2024

They aren't though, both Q3 and W:ET in my case have surfaceparm nonsolid in common/nodraw

from netradiant-custom.

Garux avatar Garux commented on September 26, 2024

This is known confusion, OG Q3 shader has both nodraw and nodrawnonsolid... nonsolid :p
This used to be fixed in tweaked shaders coming with radiants, i include such shader too.

from netradiant-custom.

Aciz avatar Aciz commented on September 26, 2024

Wouldn't it be better to just not apply nodraw to anything that already isn't nonsolid? Applying caulk or even weapclip in such cases would produce same result without the unexpected change to nonsolid, and not require users to modify stock shaders, especially considering dev builds don't even ship gamepacks.

from netradiant-custom.

Garux avatar Garux commented on September 26, 2024

Okay, it would work in more cases, but it would be semantically wrong.
Caulk is for opaque solid, nodraw for trans solid, nodrawnonsolid for trans nonsolid, weapclip for weapclip.
This serves better map visual structure and filtering by texture.
Dev builds ship gamepacks, they do not include shaders/textures. Working on this atm.

from netradiant-custom.

Aciz avatar Aciz commented on September 26, 2024

I really don't agree that the solution to this is to modify stock common/nodraw though, any old map you might have that is built with the stock shaders (as you might reasonably expect) is going to behave differently if you suddenly start changing nodraw to not be nonsolid. There are many other shaders to choose from that you can use in place of nodraw to achieve the same effect it would have if it was solid.

This serves better map visual structure and filtering by texture.

Having caulk at the bottom of the ice in my example will still filter it fine when enabling translucent filter though.

from netradiant-custom.

The-Gig avatar The-Gig commented on September 26, 2024

Just on a side note, iirc years ago I did some tests trying to figure out the the difference between nodraw and nodrawnonsolid in q3, and for some reason the test brush which had nodrawnonsolid on some faces kept casting a shadow also when set as "detail", while the one with nodraw did not.... (So, for some strange reason "nodrawnonsolid" felt a bit more "solid" than the other one. Maybe due to the order of the surfaceparms? In some cases it makes a difference).
But many years passes since those tests, it's totally possible I'm recalling it completely wrong!

from netradiant-custom.

Garux avatar Garux commented on September 26, 2024

Idk where i've got that solid nodraw, but it felt like some solid source, like ydnar or obsidian.
Now i can't literally find a single solid nodraw shader source.
Needless to say, that og shaders naming is uber clunky, it should have been something around nonsolid-trans & nonsolid-opaque to respect functionality.
For latter can only imagine very exotic uses though; in Q3 maps they are used mindlessly as equals, even both on the same brush.

Since a lot of stuff has been designed with solid nodraw in mind, now workaround is to check solidity in autocaulk code and fall back to caulk, if nonsolid.

from netradiant-custom.

Garux avatar Garux commented on September 26, 2024

@The-Gig i recall same observation. Trying it now and can't tell surely how does it work xD

from netradiant-custom.

The-Gig avatar The-Gig commented on September 26, 2024

Mine was a test from 10 years ago, http://openarena.ws/board/index.php?topic=4679.msg47000#msg47000. While the screenshots there are only visible to registered forum users and registration is broken since years, the text explains the differences I did notice...

from netradiant-custom.

Garux avatar Garux commented on September 26, 2024

Described observations are in range of expectance, vis data is used for light calculation, so invisible structural brushes cast shadows.
Trans property of nodraw makes it detail, hence the difference.

As for nodrawnonsolid estimated application, it would work for turning visually normal opaque geometry to nonsolid (to simplify collision?). There are _trans (actually nonsolid) shaders in vQ3 signing in favor of this theory.

from netradiant-custom.

Garux avatar Garux commented on September 26, 2024

Can see there _trans mainly for patches.
Fun fact, this is nonsolid:
image

from netradiant-custom.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.