Create a new Evt after applying filter/operator about evt HOT 14 CLOSED

Thanks for the kind words, they mean a lot!
I appreciate your questions, as they help me understand the needs and experiences of users like you. It's always great to see people using EVT correctly.

The implementation does seem overly complex for what appears to be a simple use case

I completely agree. It's unfortunate that EVT isn't more accommodating for this valid use case. I've added two items to my roadmap to address this:

• Introduce the concept of optionality for StatefulEvt: We'd like to have a stateful EVT that, when attached, calls the handler with its current value (which is already the case) UNLESS its current value is null (or something similar).
• Make it the default behavior of pipe to ensure that if there isn't anything attached to the downstream EVT, there isn't anything attached to the source EVT either.

I'll takle this alongside the planned integration with ts-pattern

I hope performance is still fine.

I am quite confident that performance will be satisfactory. There will be a small overhead when attaching and detaching, but I believe this won't be an operation performed intensively. Additionally, the processes involved are not resource-intensive.

One final suggestion: consider abstracting this logic into a utility function to streamline the implementation.

import { Evt, type StatefulReadonlyEvt } from "evt";

/** Return a copy of the source Evt. While there isn't anything attached to the returned copy,
  *  the source evt won't be observed.  
  *  When attaching an handler to the copied Evt it will imediately be invoked with the current value
  *  of the source evt unless this value is null.
 */
function weakPipe<T>(evt: StatefulReadonlyEvt<T | null> ): Evt<T>{

    const evtOut = Evt.create<T>();

    const ctx = Evt.newCtx();

    const noSideEffect = () => { };

    evtOut.evtAttach.attach(handler => {

        if (ctx.getHandlers().length === 0) {
            evt.$attach(
                ping => ping === null ? null : [ping],
                ctx,
                ping => evtOut.post(ping)
            );
            return;
        }

        if (evt.state === null) {
            return;
        }

        const op = evtOut.getInvocableOp(handler.op);

        const result = op(evt.state, noSideEffect)

        if (result === null) {
            return;
        }

        handler.callback?.(result[0]);

    });

    evtOut.evtDetach.attach(
        () => evtOut.getHandlers().length === 0,
        () => ctx.done()
    );

    return evtOut;


}

const evtPing = Evt.create<string | null>(null);

const evtPingCopy= weakPipe(evtPing);

from evt.

Wow thank you so much for such a thourough answer! I've been a big fan ever since I came across Evt but some of these concepts a still a bit beyond me, slowly learning more about them.

Pothos can indeed call the subscribe multiple times at once, so I've tried implementing your second solution and it works like a charm, exactly as I expected.

It does seem overly complex for what seems like a simple use case, I hope performance is still fine.

I could allow graphql to return null, that might simplify the solution but when filtering I think you're still back to having all this logic. I'll have to think if it's better to apply the filter earlier and split the events over multiple Evt intances, instead of trying to shove different events over one Evt.

Anyway this gives me options to experiment and find the best fit for me, thank you so much!

from evt.

Cheers! so for .attach() the handler.callback() does work immediately, but for some reason for async iterators it needs to wait a tick. Is that a bug in Evt, or a drawback of how async iterators work?

I replaced Promise.resolve().then() with process.nextTick(), although that's less portable, it seemed more fitting.

Thanks for all the effort helping me 👍 It's been fun learning more about this.

from evt.

The initial attach needed the same treatment

if (ctx.getHandlers().length === 0) {
  evt.$attach(
    (value) => (value === null ? null : [value]),
    ctx,
    (value) => Promise.resolve().then(()=> evtOut.post(value))
  );
  return;
}

from evt.

Hold on

from evt.

I've found .iter() seems to provide the functionality I'm looking for. But after some testing this has the same problem that handlers are not being cleaned up.

subscribe: function () {
    console.log(`handlers: ${pingEvent.getHandlers().length}`)
    const event = pingEvent.state
        ? pingEvent
        : pingEvent.toStateless();
    return event.iter(event => event === 'some filter');
}

the following shows increased handler count every new subscription. so the iterator.return() is not being hanled as exepcted when evt.iter() is used?

Edit: okay it is the. .toStateless() that prevent the handlers from being cleared. So if I avoid using that I can go ahead and filter with .iter().

I was getting the following error

Cannot pipe StatefulEvt because the operator does not match it's current state. You would end up with evt.state === undefined Use evt.toStateless([ctx]).pipe(op).toStatic(initialState) to be sure the StatefulEvt does not have an undefined state

Which is why I implemented the .toStateless() but I'll have to find another way to be able to filter without triggering this error.

from evt.

Hi @barthuijgen,

You are raising valid points. Evt needs something like a bidirectional pipes.

I offer you two solutions:

The naïve one (that work as long as Photos only subscribe at most one handler at the time):

import { Evt } from "evt";

const evtPing = Evt.create<string | null>(null);

const evtStatelessPing = (()=>{

    const ctx= Evt.newCtx();

    const evtStatelessPing = evtPing
        .toStateless(ctx)
        .pipe(ping => ping === null ? null : [ping]);

    evtStatelessPing.evtDetach.attachOnce(()=> ctx.done());

    if( evtPing.state !== null ){
        evtStatelessPing.postAsyncOnceHandled(evtPing.state);
    }

    return evtStatelessPing;

})()

The solution without making any assumption whatsoever.

import { Evt } from "evt";

const evtStatelessPing = (() => {

    const evtStatelessPing = Evt.create<string>();

    const ctx = Evt.newCtx();

    evtStatelessPing.evtAttach.attach(handler => {

        if (ctx.getHandlers().length === 0) {
            evtPing.$attach(
                ping => ping === null ? null : [ping],
                ctx,
                ping => evtStatelessPing.post(ping)
            );
            return;
        }

        if (evtPing.state === null) {
            return;
        }

        const op = evtStatelessPing.getInvocableOp(handler.op);

        const result = op(evtPing.state, () => { })

        if (result === null) {
            return;
        }

        handler.callback?.(result[0]);

    });


    evtStatelessPing.evtDetach.attach(
        () => evtStatelessPing.getHandlers().length === 0,
        () => ctx.done()
    );

    return evtStatelessPing;

})();

from evt.

The first solution assumes Pothos will only suscribe at most one handler to the Evt.

The second make no assumption.

The code can be simplified a lot if you don't care about posting the initial ping state when the subscription is made by Pothos.

from evt.

This is the code if you don't need to post the initial state:

const evtStatelessPing = (() => {

    const evtStatelessPing = Evt.create<string>();

    const ctx = Evt.newCtx();

    evtStatelessPing.evtAttach.attach(
        () => ctx.getHandlers().length === 0,
        () => evtPing
            .toStateless(ctx)
            .$attach(
                ping => ping === null ? null : [ping],
                ping => evtStatelessPing.post(ping)
            )
    );

    evtStatelessPing.evtDetach.attach(
        () => evtStatelessPing.getHandlers().length === 0,
        () => ctx.done()
    );

    return evtStatelessPing;

})();

from evt.

Let me know if you need further explanation, I'm happy to answer.

from evt.

That's great, good luck on working on those improvements, looking forward to any progress. That ts-pattern lib looks pretty neat as well, will give a try sometime.

I think there is a slight issue with the weakPipe unless I'm misunderstanding it's implementation. Currently I need to call weakPipe(evtPing) every time in the graphql subscription for it to work as expected. If I re-use the evtPingCopy then it only works the first time it is used, on a subsequent request it will not pass along any data.

It works fine just re-doing the weakPipe for every sub, which might be what you intended anyway. But from reading the code it felt like after ctx.done() it should be able to attach a new handler.

from evt.

@barthuijgen I'm verry sorry.
I should have tested the code before submiting it to you.
I forget about:

Here is the updated code:

import { Evt, type StatefulReadonlyEvt } from "evt";

/** Return a copy of the source Evt. While there isn't anything attached to the returned copy,
  *  the source evt won't be observed.  
  *  When attaching an handler to the copied Evt it will imediately be invoked with the current value
  *  of the source evt unless this value is null.
 */
function weakPipe<T>(evt: StatefulReadonlyEvt<T | null> ): Evt<T>{

    const evtOut = Evt.create<T>();

    let ctx = Evt.newCtx();

    const noSideEffect = () => { };

    evtOut.evtAttach.attach(handler => {

        if (ctx.getHandlers().length === 0) {
            evt.$attach(
                ping => ping === null ? null : [ping],
                ctx,
                ping => evtOut.post(ping)
            );
            return;
        }

        if (evt.state === null) {
            return;
        }

        const op = evtOut.getInvocableOp(handler.op);

        const result = op(evt.state, noSideEffect)

        if (result === null) {
            return;
        }

        handler.callback?.(result[0]);

    });

    evtOut.evtDetach.attach(
        () => evtOut.getHandlers().length === 0,
        () => {
            ctx.done();
            ctx = Evt.newCtx();
        }
    );

    return evtOut;

}

const evtPing = Evt.create<string | null>(null);

const evtPingCopy= weakPipe(evtPing);

from evt.

Don't worry about it! I'm testing further and notice that it's not posting the initial state, not on first use or subsequent usage.

I tried to re-create Pothos's use of async iterators in a stackblitz but it's not exactly the same, I was able to reproduce the issue.

https://stackblitz.com/edit/evt-playground-syzowb?file=index.ts

As you can see in the last one I also expected iterator copy:pong 2 to appear in the end. sorry that it's a bit messy.

This problem seems to be unique to using async iterators, because if I swap those out with regular .attach() it works as expected again.

I've updated my project with a different workaround for now, so I dont need this method. just wanted to let you know my findings :)

from evt.

I'm sorry I wasn't able to produce a working solution.

Here is a fix:

-handler.callback?.(result[0])
+Promise.resolve().then(()=>handler.callback?.(result[0]));

https://stackblitz.com/edit/evt-playground-7wpacg?file=index.ts

from evt.