Comments (7)
Just verified, yes, it doesn't crash now and the algorithm results are fully correct. Thank you so much, our project will probably switch back to priority_queue!
from priority-queue.
To clarify: I was using the priority queue differently beforehand, inserting all graph nodes which means about 50 million for my largest dataset. However, this new method keeps the number of current nodes commonly below 100, which either way didn't solve the issue described.
from priority-queue.
Hi @kleinesfilmroellchen, sorry for the delay, but I have been very busy and I could not respond to this issue as promptly as I wanted.
Can you please provide me a sequence of operations that make the queue crash? It would be very useful to find the bug.
Thanks in advance
from priority-queue.
That's hard to do, as the bug usually occurs after several thousand operations on the queue. However, through some debugging I found the following:
- When an element is pushed into the queue, it appears to be added to the IndexMap correctly.
- However, when later the queue is heapified, this element is missing. When debug printing
self.store.map
in the closure after map.rs line 651, it crashes. Modifying the debug implementation to not unwrap, the output data structure has a singleNone
at the newly added item. As far as I can tell (the internal data structures are hard to understand) this means that the element is in the heap, but not in the index map (or something? idk). The element is currently at the end after being inserted, so maybe that also plays into it. Honestly, the control flow is too hard for me to understand and I gave up. - The bug appears both with
heapify_min
andheapify_max
, though I have only deeply investigatedheapify_max
. It also happens when manuallyheapify()
-ing the priority queue (I made the function public for testing) after performing push(). Though I don't know if that should just be no-oping or if the data structure can't handle multiple (manual) heapifications.
Hope this helps. I have to switch to standard library BinaryHeap because deadline, but thanks for investigating this.
from priority-queue.
Thank you for your report. Could you post at least the full log? It would be very helpful
from priority-queue.
I don't quite understand. What I posted above is the full log, everything else is stuff from my application. I just added a {:#?}
to print the queue. To print all queue states is impossible; they easily fill up my terminal history by the time it crashes.
from priority-queue.
@kleinesfilmroellchen I think I fixed the bug and I could not reproduce it anymore. I would be very grateful if you could confirm it. Thank you in advance for your time
from priority-queue.
Related Issues (20)
- changing priorities via `iter_mut` doesn't work as I expected HOT 4
- Float as Priority HOT 2
- Bug in PriorityQueue::remove() HOT 3
- Documentation does not specify behavior for equal priorities HOT 3
- Function to remove item with least priority HOT 7
- Remove Sized bound for some functions HOT 1
- Implement a DoublePriorityQueue HOT 1
- clear_over(priority) and clear_under(priority) HOT 3
- iter_over(priority) and iter_under(priority) HOT 2
- Add a pop_lowest_priority API HOT 3
- Bug in DoublePriorityQueue.peek_min() HOT 6
- "error: could not compile 'priority-queue'" on nightly rust build HOT 2
- Add option for duplicate/unhashable Items HOT 2
- Feature Suggestion: DoublePriorityQueue with multiple priorities
- Difference between `push` and `change_priority` unclear HOT 1
- Feature request: `drain_filter` method HOT 1
- Use complex data structure as Priority HOT 1
- `shrink_to_fit` does not shrink the internal IndexMap
- ahash < 0.8.7 broken on nightly HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from priority-queue.