Git Product home page Git Product logo

Comments (5)

garris avatar garris commented on September 17, 2024

I can tell from your wish list that we are on the same page. All this stuff makes total sense. Even without tests I am really happy to pull this stuff in -- it's worth the short term regression risk. I would also add that I've gotten a lot of feedback on adding a ready event listener to the config -- e.g. a developer could emit a 'myAppIsReady' event on the body or in the console and BackstopJS would wait to test until that event is fired. This would really be easy to implement in Casper.

From the feedback I am getting I know the changes you're proposing, in addition to the ready event would create a lot of happiness.

Please do it and request the pull -- let me know if you need any support!

from backstopjs.

garris avatar garris commented on September 17, 2024

if you do go ahead with the changes -- I would just suggest you set the default reference directory location to be in parallel with the backstop.json file. It would simplify the on-boarding process for new users.

from backstopjs.

garris avatar garris commented on September 17, 2024

Hey Peter, I just wanted to check in with you. There has been considerable work done on BackstopJS: updating to an all-NPM install, simplifying the config files, adding custom screenshot events and cleaning up some of the underlying Gulp code. One of the next items would be the customizable screenshot location -- this is one of the items you had proposed above.

I wanted to see if you had gotten anywhere with that or if you still had any intentions of doing so. Please let me know. Best regards. GS

from backstopjs.

peter-mouland avatar peter-mouland commented on September 17, 2024

I went a slightly different direction and built this: https://github.com/skyglobal/Sheut

relies on node-canvas and is pain having to install cario...

from backstopjs.

garris avatar garris commented on September 17, 2024

Looks like it's all server side -- that's cool. Alright then, best of luck with it. Take care. GS

from backstopjs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.