Git Product home page Git Product logo

Comments (2)

Diaphteiros avatar Diaphteiros commented on July 18, 2024 1

I think you slipped by one line in the last code snippet, it should be merged into config and not into config.controllers.
But that looks good otherwise, I would have proposed to do it the same way.

from garden-setup.

SimonKienzler avatar SimonKienzler commented on July 18, 2024

This turned out less straight-forward than I thought. Spiff can't do deep merges, therefore inserting the merge underneath gardener.values.global.controller.config doesn't bring in deeper nested fields (like controllers.project.staleGracePeriodDays). Same problem as in #656 I think.

I will open a PR to merge the custom options underneath gardener.values.global.controller.config.controllers instead, because the stale project config is what we actually need.

from garden-setup.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.