Git Product home page Git Product logo

Comments (6)

tshemsedinov avatar tshemsedinov commented on July 30, 2024 1

code style doesn't looks like after default config

from hermit.

gapiyka avatar gapiyka commented on July 30, 2024

Hi there @tshemsedinov ✋🏿
If I'm not mistaken, in last commit prettier commit i added prettier extension with default settings configurations(but also switch on a func: indent lines with tabs ) and run all code through it 🛠

**eslint was installed from the start of project

from hermit.

tshemsedinov avatar tshemsedinov commented on July 30, 2024

eslint and prettier are not an extension for your IDE, they are dependencies, you need package.json, .prettierrc, .eslintrc.json, see example: https://github.com/metarhia/metacom

from hermit.

gapiyka avatar gapiyka commented on July 30, 2024

bruh

I tried to do what u suggest -___-
Is it correct now? Check in new one commit.

  • initialize package.json
  • add package.json, .prettierrc, .eslintrc.json files
  • change config on default from metarhia rep.

image

from hermit.

tshemsedinov avatar tshemsedinov commented on July 30, 2024

Improve code style where possible

  • You still have multiple magic numbers
  • Use collections instead of switch/case (and if/else blocks)
  • Avoid code duplication, create abstractions (classes, functions)
  • Fix naming

from hermit.

gapiyka avatar gapiyka commented on July 30, 2024

👨🏻‍🔧👨🏻‍🔧👨🏻‍🔧👨🏻‍🔧👨🏻‍🔧👨🏻‍🔧👨🏻‍🔧👨🏻‍🔧👨🏻‍🔧
Remade in those two commits:

👨🏻‍🔧👨🏻‍🔧👨🏻‍🔧👨🏻‍🔧👨🏻‍🔧👨🏻‍🔧👨🏻‍🔧👨🏻‍🔧👨🏻‍🔧

from hermit.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.