Git Product home page Git Product logo

Comments (13)

ganlanyuan avatar ganlanyuan commented on July 30, 2024

Hi,
Thanks for your feedback!
Would you mind to use padding instead of margin?

from tiny-slider.

ganlanyuan avatar ganlanyuan commented on July 30, 2024

0.4.0 add a gutter option which can be used to set the margin.
Please let me know if this fix your issue.
Thanks

from tiny-slider.

faboulaws avatar faboulaws commented on July 30, 2024

Thanks for the quick fix. The gutter option works well with maxContainerWidth and loop = true. I still had to change logic so that gutter is used as marginLeft instead of marginRight of each slide item. This means that there might be a need for another option to specify where(left/right) the margin should be added for each item.
Thanks

from tiny-slider.

ganlanyuan avatar ganlanyuan commented on July 30, 2024

An option gutterPosition is now available to change this from v0.4.1. Could you check it?

from tiny-slider.

faboulaws avatar faboulaws commented on July 30, 2024

Hi Again

gutterPosition works great but there is and left margin added to the slider that in my case I dont need.

this code
if (gutter !== 0 && gutterPosition === 'marginLeft') { ml = (loop)? itemsMax * slideWidth + gutter : gutter; }

when replaced with

if (gutter !== 0 && gutterPosition === 'marginLeft') { ml = (loop)? itemsMax * slideWidth : gutter; }

works for me

from tiny-slider.

ganlanyuan avatar ganlanyuan commented on July 30, 2024

Is it because you already have margin-left in you css, so you don't need it?

from tiny-slider.

faboulaws avatar faboulaws commented on July 30, 2024

Hi
I dont have a left margin. In my case I need the left margin of the first item to be visible.
Thanks

from tiny-slider.

ganlanyuan avatar ganlanyuan commented on July 30, 2024

So you want only the first item shows left margin, other items don't show margin, is this the point?

from tiny-slider.

faboulaws avatar faboulaws commented on July 30, 2024

I have a carousel where the items are not close to each other. So The need for the left margin. Also there is a space between the first item and the the beginning of the slider.

Please see a quick example of the layout below. It shows the first 2 items in the slider

<-----><------------><-----><------------>
margin, first item, margin, second item

Thanks

from tiny-slider.

ganlanyuan avatar ganlanyuan commented on July 30, 2024

How about the last one?
Is there some margin between the last item and the end of the slider?

from tiny-slider.

faboulaws avatar faboulaws commented on July 30, 2024

No there is not.
Thanks

from tiny-slider.

ganlanyuan avatar ganlanyuan commented on July 30, 2024

Hey, sorry I can't do like your case because usually the first and last slider items are vertical aligned with the slider.
But you can modify it to fit your need like what you mentioned before:
Replace

ml = (loop)? itemsMax * slideWidth + gutter : gutter;

with

ml = (loop)? itemsMax * slideWidth : gutter;

from tiny-slider.

faboulaws avatar faboulaws commented on July 30, 2024

Ok. Thanks so much for your help

from tiny-slider.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.