Comments (6)
One option to implement this is trapz_loglog in gammafit
.
We could also try UnivariateSpline
in loglog
space.
from gammapy.
Update: we now have gammapy.spectrum.integrate_spectrum.
- move to a method on the gammapy.spectrum.models.SpectralModel class.
- find good settings to get results with reasonable accuracy and speed for most models.
from gammapy.
from gammapy.
@joleroi - I know. I'll close these spectrum integral issues in the next days. I just want to do some more testing and clean-up of old code, and keep them as a reminder.
from gammapy.
Is there anything left to be done for this issue? Compare against gammalib?
from gammapy.
This is a key piece of spectral analysis, and probably there will still be a lot of work on getting the precision / speed trade off right in Gammapy, and https://github.com/joleroi/wstat/issues/12 might be related, i.e. things can improve a lot by changing to integrating over bins use power-law approximation over bins by default instead of a simple diff flux times bin width method (cc @joleroi).
But the main thing suggested above was implemented by you a few months ago, and there is no concrete action item here, so I'm closing this issue. We can re-open or file new issues in the future when we encounter precision or speed problems from Gammapy spectral analyses.
from gammapy.
Related Issues (20)
- Check that tutorials run as notebooks HOT 6
- get_overlap_fraction fails for different units in true and reco axis
- Addition of EnergyDependenceEstimator
- Issues with RandomState and reproducible inverse CDF sampling
- Plotting error region for shell spatial models
- Documentation of `SpectrumDatasetMaker` is misleading.
- Adapt SensitivityEstimator to support MapDataset and joint datasets
- Ideas for the high level interface HOT 1
- About the many correct ways to compute differential sensitivity HOT 2
- Background2D.to_3d uses cartesian not angular distance HOT 1
- Show default model parameters values into the docstring
- Add DarkMatterDecaySpectralModel HOT 1
- Please revise get_wstat_mu_bkg HOT 9
- Change `write` API for `TemplateSpatialModel`
- `DarkMatterAnnihilationSpectralModel` not readable from `Models.read`
- Removing numpy deprecation warnings when arrays of size 1 are treated as scalars
- CI failing with matplotlib 3.8 HOT 2
- Unkown `Note` section in docstring are not shown in docs. It should be Notes HOT 5
- Show default model (spatial and temporal) parameter values in docstring
- Arguments of the class `Observation' to be described
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gammapy.