Git Product home page Git Product logo

Comments (16)

games647 avatar games647 commented on July 17, 2024

Is there a possibility to check if the user is in the FastLogin database instead of the AuthPlugin database? Because I have seen ~5 players that didn't exist in the FastLogin database but they did exist in the AuthMe database. So they still need to use /login password and the didn't have a skin.

FastLogin does that to protect cracked players from stealing their account. Do you mean those should have been auto registered?

from fastlogin.

Tim-NL avatar Tim-NL commented on July 17, 2024

Yes those accounts should be autoregistered, they are premium (for what NameMC says), but they only got added to the AuthMe database. And because FastLogin checks if the player is registered there it won't make a request to Mojang so those accounts stay "locked" for the owners until I add them manualy.

from fastlogin.

games647 avatar games647 commented on July 17, 2024

Maybe they were registered even before FastLogin knows those players

from fastlogin.

Tim-NL avatar Tim-NL commented on July 17, 2024

No they are not, I installed AuthMe & FastLogin together, my server was premium only before I stared using FastLogin and both database where empty :)

from fastlogin.

games647 avatar games647 commented on July 17, 2024

I could be caused by an old version. Are they new players, because FastLogin doesn't remove anything?

from fastlogin.

Tim-NL avatar Tim-NL commented on July 17, 2024

Well, the player will get autoregistered (They have an account) but they don't know the password. And the player isn't added to the FastLogin database. So the autoregister thing works? But the autologin doesn't because the player doesn't exist in the FastLogin database.

from fastlogin.

games647 avatar games647 commented on July 17, 2024

FastLogin only inserts the player record if it got a success notification from bukkit.

Are those new players?

from fastlogin.

Tim-NL avatar Tim-NL commented on July 17, 2024

Kind off, they have been in that lobby map before but then the lobby didn't have a account on AuthMe because I didn't have that plugin.

from fastlogin.

games647 avatar games647 commented on July 17, 2024

So I mean new authme players?

from fastlogin.

Tim-NL avatar Tim-NL commented on July 17, 2024

Yes they are new AuthMe players, but if I'm the only one with this problem I can make a small work around for myself. And it only seems to happen to ~5 players and my server has 1050 players registered since I'm using fastlogin.

(My idea (for myself (isn't a good idea for a public plugin I think.);
When a player joins the server and they didn't login within 10 seconds > send a request to mojang that asks if the user is premium, and if he is I'll add them manual to the fastlogin database using a SQL query. I think that should work, but it isn't the best solution :P

from fastlogin.

games647 avatar games647 commented on July 17, 2024

And it only seems to happen to ~5 players and my server has 1050 players registered since I'm using fastlogin.

Report me if it happens again for a new player. I'll look into it maybe I find something.

When a player joins the server and they didn't login within 10 seconds > send a request to mojang that asks if the user is premium, and if he is I'll add them manual to the fastlogin database using a SQL query. I think that should work, but it isn't the best solution :P

The problem is you have to validate that it's really the owner of that premium account. This can only be done during the login phase.

from fastlogin.

Tim-NL avatar Tim-NL commented on July 17, 2024

The problem is you have to validate that it's really the owner of that premium account. This can only be done during the login phase.

I know, but I think fastlogin handles that? if FastLogin thinks a premium player is cracked (and some random player joined using that playername) and my plugin will make that player (the name & UUID from mojang) premium by adding them to the fastlogin database. And kicking them after its done.

And if that player joins again (cracked) he won't be able to login because he is set as premium within fastlogin. So only the owner will be able to play after the manual insert?

(Namecheck & Autoregister == true)

from fastlogin.

games647 avatar games647 commented on July 17, 2024

This means you want to make premium players be able to steal the account of a cracked one (same username)?

from fastlogin.

Tim-NL avatar Tim-NL commented on July 17, 2024

Oh no, I'll make a get request to Mojang first to check if the name is premium :) And if he is I'll add him.

from fastlogin.

games647 avatar games647 commented on July 17, 2024

But this means cracked player accounts who uses premium usernames are insecure. Examples

New premium player bough that name
Premium player changed his/her name to that cracked player

from fastlogin.

Tim-NL avatar Tim-NL commented on July 17, 2024

Hmm indeed, I think that chance is small on my server. I only have 19 players as cracked (Authme rows - Fastlogin rows) So that isn't a big problem.

But I think i can do;
Runnable (10 seconds)
Didn't login yet? >
Request UUID from mojang >

Player is cracked > Add him to my own database (only for cracked players)

Player is premium > Check if that name exists in my own database if not >
Register player in the FastLogin database and if he is in my own database just return and do nothing.

EDIT:
I think i can lower the waiting time to 5 seconds, so all cracked players will be added to the "cracked" list.

from fastlogin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.