Application.ApplicationOK doesn't check for expected number of tasks about go-marathon HOT 4 CLOSED

Sorry for the delay ... Admittedly i'm not sure how best to get these numbers either ... I'll have a look into it though ..

from go-marathon.

Might be overthinking it ... perhaps just checking the tasks count == application instances requested when deployed is enough. Though i recall there was an issue if the application is deployed via a group, as internally marathon set the .instances variable to zero and use's as a means to control dependencies

// step: does the number of tasks match the number of tasks?
if !application.AllTaskRunning() {
    return false, nil
}

and the AllTaskRunning() method

func (application *Application) AllTaskRunning() bool {
    if application.Instances == 0 {
        return true
    }
    if application.Tasks == nil {
        return false
    }
    if application.TasksRunning == application.Instances {
        return true
    }
    return false
}

from go-marathon.

That check does seem like it should work. I guess I'll need to make multiple calls to make sure the tasks stay running for a few seconds. Thanks for looking into it!

from go-marathon.

This seems fixed, so I'm closing the ticket. Please reopen in case there's still something missing.

from go-marathon.