wait_on_running in CreateApplication immediately times out about go-marathon HOT 3 CLOSED

Changing the wait_on_running from a boolean to a time.Duration and pass through to WaitOnApplication() would make sense ... The fact it's terminating straight away is a bit odd though, as a value of zero passed to WaitOnApplication() is defaulted to DefaultDeploymentTimeout: time.Duration(300) * time.Second config.go

what version of marathon you running? and go?... did the app start or error out? ..

func (client *Client) CreateApplication(application *Application, wait_on_running bool) error {
    result := new(Application)
    client.log("Creating an application: %s", application)
    if err := client.apiPost(MARATHON_API_APPS, &application, result); err != nil {
        return err
    }
    // step: are we waiting for the application to start?
    if wait_on_running {
        return client.WaitOnApplication(application.ID, 0) <--
    }
    return nil
}

func (client *Client) WaitOnApplication(name string, timeout time.Duration) error {
  // <--- clutching as straws, but perhaps different versions of go handle the value differently and evaluates > 0 thus wouldn't inherit the default 300??? 
    if timeout <= 0 { 
        timeout = client.config.DefaultDeploymentTimeout
    }
   ....

from go-marathon.

I took a closer look through your examples and realised that I was just not setting the client up correctly. I was initiating it with
client, _ := marathon.NewClient(marathon.Config{URL: url}) which of course meant that the DefaultDeploymentTimeout was not set.

Thanks for the response, and sorry for taking up your time.

from go-marathon.

Perfect :-) ... thanks for getting back ..

from go-marathon.