Comments (7)
I think it's the same purpose as here: https://github.com/kubernetes/kubernetes/blob/master/pkg/client/unversioned/client.go#L35
it will allow easier mock testing, so user can inject another mocked marathon client instead of creating a wrapper. In this case it'd be nice to provide this mock implementation.
from go-marathon.
I was also thinking that the purpose is testing-related.
The other alternative I heard of is to use more broad interfaces, like Readers and Writers. I've never tried that approach for something other than very small interfaces, however.
from go-marathon.
I like that mocking idea. Now that I start thinking about this, wouldn't it be nice, if go-marathon offered a marathon mock implementation?
func NewMockClient(config Config) (Marathon, error)
from go-marathon.
I was thinking the same already but would opt for a fake instead. Unlike a mock where you need to specify behavior (which is an implementation detail), a fake exposes the same API but comes with a simplified implementation. In our case, we'd probably want an in-memory backend instead of a full-blown cluster. See also this Google TotT blog post on the subject (and this and this related post, respectively).
To be fair, we might need mockish properties to test certain scenarios (like failure behaviors). Those could come in addition to a regular fake, however.
from go-marathon.
wouldn't it be nice, if go-marathon offered a marathon mock implementation?
I was just thinking about it and I didn't come up with an idea how to do it in a simple and flexible way. User needs a way to precisely specify what needs to be returned from a specific marathon call. Maybe I need to check kubernetes code more.
Another idea could be is to provide a fake marathon server (we already use something similar in our tests). In this case it would be crystal clear how to use it + it will be used in our tests as well, so we can re-use code in our tests and expose it for users.
In case we'll choose this approach we can get rid of the interface.
from go-marathon.
I'd rename the issue to something like Build Marathon API test double at this stage.
from go-marathon.
Closing in favor of #108
from go-marathon.
Related Issues (20)
- TestRegisterSEESubscriptionReconnectsStreamOnError fails on windows HOT 7
- Example panics on Marathon 1.4
- Application API should support `embed` arguments HOT 2
- Missing Version API HOT 1
- latest master fails to compile HOT 3
- Marathon hosts marked as down never become healthy with Marathon 1.4.4 HOT 3
- Http client configuration no longer honored for event stream connections HOT 5
- When a member is marked down, we ping Marathon to death HOT 3
- Marathon 1.5 API Support HOT 26
- lastTaskFailure is always nil HOT 1
- example in readme doesn't compile HOT 2
- Issues regarding to SSE events HOT 5
- Remove dependency on plan field
- Client should be updated to follow /v2/events redirection responses
- Can wipe task support?
- Closing SSE Subscriptions
- Support for fetching files from task sandbox HOT 3
- MESOS Container Type Support
- Support CSI Volume definition
- Consider making a new release?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-marathon.