Allow custom assert code about ivory HOT 7 CLOSED

Thanks for the bug report. You're right, our current method for dealing with assertions is pretty anti-modular, and we should be able to do a lot better.

I'll talk with the rest of the team about this on Monday, and we'll come up with something that works with all of our existing Ivory targets, and allows the user to pick a more flexible assertion implementation.

from ivory.

I think @expipiplus1's suggestion is completely reasonable. Are there any reasons not to?

from ivory.

There may need to be a mechanism to put the users ivory_assert in scope everywhere.

from ivory.

I'd prefer not to give the user arbitrary control of includes and macros in the Ivory runtime if we can avoid it. Here is a proposed solution which allows the user to provide an assertion hook as a library. I made this a bit flexible with a verbose user hook as an option. This is configurable because users might not have room for __FILE__ and __LINE__ constants on embedded systems with limited program size.

from ivory.

Often it's nice to have the expression for arg as a string when printing asserts in addition to file and line.
Changing the line in the verbose definition for ivory_assert to ivory_user_verbose_assert_hook(atype, #arg, __FILE__, __LINE__);

from ivory.

That suggestion sounds good to me. I'll merge this with master as soon as we work out what the assert hooks will be for each of our user's platforms.

from ivory.

assert hooks are now in master. Thanks again for this bug report!

from ivory.