Error reporting in 'encode' about cereal HOT 4 CLOSED

Hi,

Is your worry here that the default implementation of put for a ByteString will encode its length as Word64? If so, you can just use putByteString to put directly to the output buffer, choosing your own mechanism for length encoding.

If your worry is that ByteString uses a platform-dependent representation for lengths that could be Int32 or Int64, then I would suggest just doing the validation before running the rendering operation, as there's not really a good way to tie the length of a ByteString to its type, currently.

I'm reluctant to add error checking to the Put monad, as it's already slower than Get :)

from cereal.

I see, do you suggest adding validation before calling put or inside Put instance?

from cereal.

I would do validation before. I'd also advise against using the Serialize class if you're parsing something that's not already a haskell value. The Serialize class makes it easy to dump a haskell value out to be read back in later on, but it makes assumptions about how data gets parsed and rendered that aren't always consistent with other formats. Falling back on the primitives that are exported by Data.Serialize.Get and Data.Serialize.Put gives you much more control over how your data is processed.

from cereal.

Well, I guess this pretty much resolves the issue :) thank you

from cereal.