Git Product home page Git Product logo

Comments (5)

jedwards1211 avatar jedwards1211 commented on August 17, 2024

I should add, I am dynamically choosing whether to render a ReduxDashboardView or another view type in the following parent ViewHolder component. Could this potentially be interfering with hot reloading? Would React.createElement interfere?

import React, {Component} from 'react';
import ImmutablePropTypes from 'react-immutable-proptypes';
import {connect} from 'react-redux';

import Alert from 'mindfront-react-components/bootstrap/Alert';

import viewTypes from 'viewTypes';

class ViewSwapper extends Component {
  static propTypes = {
    params: React.PropTypes.shape({
      viewId: React.PropTypes.string.isRequired,
    }).isRequired,
    model:        ImmutablePropTypes.shape({
      type:         React.PropTypes.string.isRequired,
    }),
    sessionState: React.PropTypes.object,
  }
  render() {
    let {model, params: {viewId}} = this.props;
    if (!model) {
      return <Alert.Danger>
        View {viewId} not found
      </Alert.Danger>;
    }
    let viewType = viewTypes[model.get('type')];
    if (viewType) {
      return React.createElement(viewType.component, this.props);
    }
    return <Alert.Danger>
      View settings for view {viewId} appear to be corrupted
    </Alert.Danger>;
  }
}

export default class ViewHolder extends Component {
  static propTypes = {
    params: React.PropTypes.shape({
      viewId: React.PropTypes.string.isRequired,
    }).isRequired,
  }
  selector = (state) => {
    let viewId = this.props.params.viewId;
    return {
      model:        state.getIn(['views', viewId]),
      sessionState: state.getIn(['viewSessionStates', viewId]),
    }
  }
  render() {
    return React.createElement(connect(this.selector)(ViewSwapper), this.props, this.props.children);
  }
}

from react-transform-hmr.

gaearon avatar gaearon commented on August 17, 2024

This is currently a limitation of babel-plugin-react-transform.
I'll try to fix it later this month.
Please track gaearon/babel-plugin-react-transform#26.

from react-transform-hmr.

jedwards1211 avatar jedwards1211 commented on August 17, 2024

Cool, thanks!

from react-transform-hmr.

gaearon avatar gaearon commented on August 17, 2024

You might be interested in reduxjs/redux#1455.

from react-transform-hmr.

jedwards1211 avatar jedwards1211 commented on August 17, 2024

Ah, I haven't used that preset, thanks for letting me know!

from react-transform-hmr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.