`ctr_build_string function` needs some works for test 48 about citrine HOT 5 CLOSED

Wow.. now I understood the error message I was getting.

You have a few errors:

You're trying to free memory that's not heap memory. Don't do that.

You're trying to free the inside of a block of memory. When you have in fact allocated a block of memory, you can only free it from the pointer returned by malloc. That is to say, only from the beginning of the block. You can't free a portion of the block from the inside.

http://stackoverflow.com/questions/20297524/c-free-invalid-pointer

from citrine.

Yes this needs some work.

from citrine.

I just tried something after meditating over this issue. I found that ctr_build_string accepts strings on the heap and stack, and that is why it trigged free invalid pointer error. So, this is what I did and it passed test cases. I found every function inside base.c file that calls ctr_build_string and for anyone that has string on the heap I added the below:

ctr_object* result;
result = return ctr_build_string(dest, nlent);
free(dest);
return result;

Please go through and comment. I tend to spend more time studying and assimilating citrine source code.

from citrine.

maybe a macro would be better for this?

from citrine.

I think this issue is no longer relevant, most/all memory issues in String, File, Map and Array have been fixed. I only need to test Nil, Object, Boolean, Number, Blocks and the system library but these are low risk and easy to test.

from citrine.