Git Product home page Git Product logo

Comments (2)

mintyc avatar mintyc commented on May 18, 2024

I'm new to git, but I've sent a git pull request with this change (and another to allow build/run for bench)

Dummy implementation - does nothing
Remove the #ifdef linux elsewhere and add a dummy impl in syslog_sink.h

git diff 'patch'

diff --git a/include/spdlog/sinks/syslog_sink.h b/include/spdlog/sinks/syslog_sink.h
index 1d7c28d..d5a20ec 100644
--- a/include/spdlog/sinks/syslog_sink.h
+++ b/include/spdlog/sinks/syslog_sink.h
@@ -24,10 +24,20 @@

 #pragma once

-#ifdef __linux__
-
 #include <string>
+#ifdef __linux__
 #include <syslog.h>
+#else
+   inline void syslog(int /*prio*/, const char */*fmt*/, ...) {}   // TODO Windows Syslog not supported
+   #define LOG_EMERG       0       /* system is unusable */
+   #define LOG_ALERT       1       /* action must be taken immediately */
+   #define LOG_CRIT        2       /* critical conditions */
+   #define LOG_ERR         3       /* error conditions */
+   #define LOG_WARNING     4       /* warning conditions */
+   #define LOG_NOTICE      5       /* normal but significant condition */
+   #define LOG_INFO        6       /* informational */
+   #define LOG_DEBUG       7       /* debug-level messages */
+#endif
 #include "./sink.h"
 #include "../common.h"
 #include "../details/log_msg.h"
@@ -84,5 +94,3 @@ namespace spdlog
     };
   }
 }
-
-#endif
diff --git a/include/spdlog/spdlog.h b/include/spdlog/spdlog.h
index 42bff20..636dbeb 100644
--- a/include/spdlog/spdlog.h
+++ b/include/spdlog/spdlog.h
@@ -69,9 +69,7 @@ std::shared_ptr<logger> stderr_logger_st(const std::string& logger_name);


 // Create a syslog logger
-#ifdef __linux__
  std::shared_ptr<logger> syslog_logger(const std::string& logger_name);
-#endif


 //

from spdlog.

gabime avatar gabime commented on May 18, 2024

Fix in commit 1008f56

from spdlog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.