Change this to a set of files for pull requests on the lessons? about js-javascripting-study HOT 12 OPEN

Yes. It should be a blank set of files ready for forking and cloning, and suitable for pull-request diffing.

Any preferences on names? I figure order doesn't matter much. Naming after each workshop lesson is obvious, but it isn't obvious whether adding numeric prefixes for order would help students.

from js-javascripting-study.

If we pursue this, it makes #1 obsolete.

from js-javascripting-study.

Should files be named NN-obvious-name.js, e.g. 00-introduction.js, 01-variables.js? With instruction? For this lesson it's not necessary and possibly confusing (file names are suggested), but for learnyounode might it be helpful (file names not suggested)?

from js-javascripting-study.

I believe we used this approach in the nodeschool assignment repo. I'd like to go with whatever is less confusing. May not know that until we try it. ;)

from js-javascripting-study.

Let's try NN-obvious-name.js. At least they sort sensibly :-P.

from js-javascripting-study.

👍

from js-javascripting-study.

@gaand do you still believe this should be a required pull request?

I can setup a sample structure in any case. Or I can let them structure however they want.

Not sure what the advantage of reviewing any PRs would be over diagnosis as a separate task.

from js-javascripting-study.

@jrhorn424 Pull request not required. If students want feedback then PR?

from js-javascripting-study.

OK, I agree. Next cohort, let's have the file structure in place in case students wish to submit a PR for feedback.

from js-javascripting-study.

Not sure this is necessary any longer. The introduction at least has you make a folder and add files.

from js-javascripting-study.

Can we incorporate that into using this repo and then requiring a pull request?

If the instructions include file names, then that should be straightforward.

from js-javascripting-study.

I agree.

from js-javascripting-study.