Git Product home page Git Product logo

Comments (11)

victorhsieh avatar victorhsieh commented on July 17, 2024

brunch looks interesting, I'll try this one :P

Hopefully #14 would be easy if we compile .md with brunch.

from g0v.tw.

victorhsieh avatar victorhsieh commented on July 17, 2024

I created a "brunch" branch for this. It's working now. As it makes incompatible change to master, does anyone want to review it first? Please advise :)

Going forward, we can make the file layout change (e.g. rm *.html, mv join news archives app/, etc.). Also, we could change the way .md files get included.

from g0v.tw.

clkao avatar clkao commented on July 17, 2024

I can take a look later today

from g0v.tw.

clkao avatar clkao commented on July 17, 2024

@victorhsieh++!

  • i see huge chunk of black html text inside footer
  • we should probably move the bootstrap less files into vendor/bootstrap
  • deploy script needs to be updated

from g0v.tw.

victorhsieh avatar victorhsieh commented on July 17, 2024

Just pushed the change. Regarding deploy, I changed build_id.txt, but other than that, it looks working to me.

Is jekyll still used at all? Should we remove it?

from g0v.tw.

clkao avatar clkao commented on July 17, 2024

don't think we need jekyll and grunt anymore. should probably remove stalled config files and update README for build instructions. also the deploy script should be looking at _public not _site

from g0v.tw.

victorhsieh avatar victorhsieh commented on July 17, 2024

One remaining issue is a runtime js error of undefined exports caused by prelude-ls. To be continued... zzz

from g0v.tw.

victorhsieh avatar victorhsieh commented on July 17, 2024

Fixed by upgrading LiveScript-brunch. I guess we can push now.

from g0v.tw.

victorhsieh avatar victorhsieh commented on July 17, 2024

Merged with master and pushed! Everything looks fine, including changes from master. I'll merge back to master later to close this :)

from g0v.tw.

carlcarl avatar carlcarl commented on July 17, 2024

@victorhsieh
Will you also close this branch, too?
Or keep this as main develop branch?

from g0v.tw.

clkao avatar clkao commented on July 17, 2024

there was a slight issue - CNAME should be in assets/. I've fixed it

from g0v.tw.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.