Gamma/brightness is incorrect on Windows about xash3d-fwgs HOT 10 CLOSED

I'm attempting to look into this using RenderDoc, but when I boot the engine I get the following message:

OpenGL. Context not created via CreateContextAttribs. Capturing disabled. Only OpenGL 3.2+ contexts are supported.

EDIT: Additionally, and very strangely, the gamma issue only seems to occur when the engine is in a widescreen resolution. If I set the video mode to something like 1024x768, the brightness of the menu looks normal, and in 1920x1080 it looks washed out. This only works if running in windowed mode - fullscreen 4:3 resolution still looks wrong.

from xash3d-fwgs.

I think it's better to trace which commit has broke the engine.

I'm still busy(until today I hope), so if you have time, you can try it by yourself. Use a bisect tool.

from xash3d-fwgs.

The problem has appeared after 4483 merge.

from xash3d-fwgs.

I'll see if I can do some more investigating today.

EDIT: Oof, that's an enormous merge...

If b797e0a is the merge you're referring to, my uninformed guess is that the most likely things to have caused the problem are the luminance images or the fog. I'll do some poking around and see if I can affect the gamma in any way by changing these.

from xash3d-fwgs.

I've tried building from the commit just before the one mentioned earlier and the problem still persists. I'll see if I can go further back.

EDIT: Narrowed down the first commit exhibiting the issue to be a1391f3. Reverting it seems to fix things. I guess it's because the offsets to skip over the unused attributes are off by 1 each time?

from xash3d-fwgs.

For me reverting a merge commit fixes everything. O_o

i.e. on 74062fa everything is fine.

These attributes are binary compatible with SDL2 and setting an offset keeps compatibility. This should be removed and proper GL_Set/GetAttribute must be implemented in engine for SDL2.

from xash3d-fwgs.

Surely that change isn't binary-compatible, though? For example:

REF_GL_ALPHA_SIZE,
REF_GL_BUFFER_SIZE, // = REF_GL_ALPHA_SIZE + 1
REF_GL_DOUBLEBUFFER // = REF_GL_ALPHA_SIZE + 2

Becomes:

REF_GL_ALPHA_SIZE,
// UNUSED_REF_GL_BUFFER_SIZE,
REF_GL_DOUBLEBUFFER // = REF_GL_ALPHA_SIZE + 1,

So the actual values of the enum constants are no longer the same. Is this what was intended?

from xash3d-fwgs.

Woops.

from xash3d-fwgs.

Ok, I will fix it in next commit. :)

from xash3d-fwgs.

Fixed.

from xash3d-fwgs.