Comments (6)
@jpleau I've reached out on the Blizzard forums to get a definitive answer on what format is expected.
from blizzard.
@jpleau can you add you comments here: https://us.forums.blizzard.com/en/blizzard/t/header-datelastmodified-format-inconsistent/15803
from blizzard.
I really think the format they use is correct. It just doesn't fit right with Go's time.RFC1123 because it fails to account for the missing zero-padding, and adding the _ allows the date to be parsed.
For example in Python you could use %d, but it will work with or without a leading zero per the documentation. Been checking my logs and it only stopped working on April 1st (since I have been working on this for a few weeks. I didn't notice it before because we were at the end of march where padding zeroes aren't a problem.
from blizzard.
@jpleau I agree and I can make the change, but I'd like to see if the Blizzard devs can confirm their intent before I make any more changes.
If you want you can make a PR with the changes and we can follow up later this week.
from blizzard.
@jpleau I never received a response and your time format seems to work. https://github.com/FuzzyStatic/blizzard/releases/tag/v1.2.2
Thanks!
from blizzard.
I'm sorry I got a bit busy with other things. Thanks for adding this!
from blizzard.
Related Issues (17)
- Http context propagation HOT 6
- The problem with card searching in HSBattlegroundsCardsSearch() HOT 1
- SC2 Ladder data for specific division's ladderID HOT 1
- Add WoW Shadowland Updates HOT 7
- Implemented Search API Calls
- Missing information with the WoW Auction House HOT 7
- WoW Auction House: Last-Modified response header HOT 4
- json: cannot unmarshal string into Go struct field CharacterProfileSummary.active_title HOT 11
- Test failing HOT 1
- Add WoW Mount Search API Call
- Add Wow Spell Search API
- Add Wow Protected Profile Summary
- Add Classic WoW PvP Season API All
- Add Overwatch League APIs
- Unable to pull the latest version HOT 1
- Error in BlizzClient.TokenValidation
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from blizzard.