Wrong time format used for date parsing for header.LastModified / Date about blizzard HOT 6 CLOSED

@jpleau I've reached out on the Blizzard forums to get a definitive answer on what format is expected.

from blizzard.

@jpleau can you add you comments here: https://us.forums.blizzard.com/en/blizzard/t/header-datelastmodified-format-inconsistent/15803

from blizzard.

I really think the format they use is correct. It just doesn't fit right with Go's time.RFC1123 because it fails to account for the missing zero-padding, and adding the _ allows the date to be parsed.

For example in Python you could use %d, but it will work with or without a leading zero per the documentation. Been checking my logs and it only stopped working on April 1st (since I have been working on this for a few weeks. I didn't notice it before because we were at the end of march where padding zeroes aren't a problem.

from blizzard.

@jpleau I agree and I can make the change, but I'd like to see if the Blizzard devs can confirm their intent before I make any more changes.

If you want you can make a PR with the changes and we can follow up later this week.

from blizzard.

@jpleau I never received a response and your time format seems to work. https://github.com/FuzzyStatic/blizzard/releases/tag/v1.2.2

Thanks!

from blizzard.

I'm sorry I got a bit busy with other things. Thanks for adding this!

from blizzard.