Comments (10)
Thanks for the report. Yes, feel free to submit a PR or I can take a look shortly.
from fusionauth-jwt.
Looking at this further, I have some tests that utilize this code path, can you provide some recreate steps to see this error?
from fusionauth-jwt.
This means tests are not running with enabled module system. I get this error when module system is enabled, otherwise there is no error.
from fusionauth-jwt.
Thanks @XakepSDK - happy to look into this and fix it. Can you please some specific recreate steps?
from fusionauth-jwt.
I made a simple reproducer, https://github.com/XakepSDK/fusionauth-testcase
How to use it:
- Clone
- Go to app dir
- Run run.sh, minimum java 9 required, if you are on windows, just run 2nd line from run.sh in cmd
- Get an error
Harder path:
- Install Intellij IDEA 2021.1.x. 2021.2.x has broken module handling. I have no idea about other IDEs
- Open project
- Launch Test class
Caveats:
- If you use gradle, then IDEA will use gradle to launch an app, looks like gradle 7 does not handle module launching at all and starts apps with classpath
- IDEA 2021.2 has broken module handling, it might work for this simple project, but in other project it didn't work
How to fix:
- Get rid of
JSONWebKeySetResponse
- Or add
opens io.fusionauth.jwks to com.fasterxml.jackson.databind
- Or make
JSONWebKeySetResponse
public with public constructor
from fusionauth-jwt.
Thanks @XakepSDK - this is great, I'll take a look.
from fusionauth-jwt.
For simplicity, I just changed JSONWebKeySetResponse
to be public
.
from fusionauth-jwt.
Fix is available in version 4.3.1
. I tested version 4.3.1
in your test project to confirm.
Thanks for the assist @XakepSDK !
from fusionauth-jwt.
You can also fix this by adding opens <package> to <jackson.databind.module>
in a module descriptor
from fusionauth-jwt.
You can also fix this by adding opens to <jackson.databind.module> in a module descriptor
Yes, I did try that, and it does work.
However the class really doesn't need to be private, so that seemed like the more correct fix from my perspective.
I suppose I could also just use a TypeLiteral
with Jackson indicate how I want to de-serialize the response, then I could just delete the class. Perhaps I'll revisit how I am marshaling this object at some point.
If you run into any other issues with the library, please do open another GH issue. Thanks for the help!
from fusionauth-jwt.
Related Issues (20)
- Add support for OAuth2 configuration HOT 8
- Add x5c and verify public key against x5c when extracting a public key from a JSON Web Key HOT 6
- io.fusionauth:fusionauth-jwt:4.0.1 has security vulnerabilities HOT 4
- README improvements
- Configurable timeouts on UrlConnection HOT 6
- Upgrade to Java >= 14? HOT 7
- Create a RSASigner.newSHA256Signer which supports PrivateKey instance HOT 2
- Will Grant Negotiation and Authorization Protocol (GNAP) working code be made available soon? HOT 2
- Embedding JWK does not yield an interoperable result HOT 3
- Overriding "configureMessageConverters" in spring HOT 2
- How to gen a jwk with kid? HOT 3
- 2047 vs. 2048 HOT 2
- Android 7 - Base64 NoClassDefFoundError HOT 1
- Decode expired JWT throws Exception HOT 2
- Best way to pull out "kid" to pick verifier? HOT 4
- Support Function<String,Verifier> for kid mapping HOT 2
- "The JWT could not be de-serialized." HOT 4
- Need Ability to Extend `Header` class HOT 2
- Fix padding on the EC signature when decoding `r` and `s` from the DER encoded value HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fusionauth-jwt.