Comments (4)
Seems related to an issue I created a while ago, although that was more of a lookup issue, and you're pointing out a design issue. #34 (comment)
A less related zipcode issue: Localities are assigned the wrong zip/postal code #56
from django-address.
PR #41 will ensure a unique locality will be generated for each combination of locality name and zip code.
from django-address.
I'll actually take this a bit further and say that postal codes should not be tied to locality at all. Postal codes are national constructs that overlay with the boundaries of metro areas.
The side effect here is that a large city like Los Angeles has > 900 zip codes which means one would end up with potentially hundreds of "Los Angeles, California, USA" entries just for separate zip codes - but the zips are inside Los Angeles, not the other way around - one city, many postal codes.
It seems like postal code should really just be an attribute of 'Address'. Or am I missing something about the design approach?
from django-address.
While the original issue described by @cassidylaidlaw has been resolved in pull/41, @explody 's structural question is still valid.
I'm closing this issue as completed, however I have made a note about considering refactoring postal code out of locality in a future release here. Please see #98 for updates on django-address
from django-address.
Related Issues (20)
- Add end-to-end tests
- Use Docker for example site HOT 2
- Admin does not query google HOT 2
- default Autofield and django 3.2
- Update translation to Django 4 HOT 1
- Nonexistent parent node ('address', '004_auto_20220227_1259') HOT 16
- Include serializers for usage inside rest framework HOT 2
- Error installing version 0.2.7 due to incorrect metadata HOT 1
- Python3.9 integration HOT 2
- Address save via admin saves the primary key into raw column, and additionally creates a bare new object HOT 3
- unique=True HOT 2
- Error when using together with Django autocomplete fields in admin HOT 3
- {{ form.media }} seems to render nothing in Django 4 HOT 2
- Address Form field only populates if full address is provided.
- Fill related models upon Address creation.
- Support for model serializer with django-rest-framework HOT 4
- Add documentation to readthedocs
- Prefer django_countries.fields.CountryField instead of implement address.models.Country
- AddressField on admin site
- Cant select address without `address_street_number`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from django-address.