Git Product home page Git Product logo

Comments (4)

jplehmann avatar jplehmann commented on July 19, 2024

Seems related to an issue I created a while ago, although that was more of a lookup issue, and you're pointing out a design issue. #34 (comment)

A less related zipcode issue: Localities are assigned the wrong zip/postal code #56

from django-address.

furious-luke avatar furious-luke commented on July 19, 2024

PR #41 will ensure a unique locality will be generated for each combination of locality name and zip code.

from django-address.

explody avatar explody commented on July 19, 2024

I'll actually take this a bit further and say that postal codes should not be tied to locality at all. Postal codes are national constructs that overlay with the boundaries of metro areas.

The side effect here is that a large city like Los Angeles has > 900 zip codes which means one would end up with potentially hundreds of "Los Angeles, California, USA" entries just for separate zip codes - but the zips are inside Los Angeles, not the other way around - one city, many postal codes.

It seems like postal code should really just be an attribute of 'Address'. Or am I missing something about the design approach?

from django-address.

banagale avatar banagale commented on July 19, 2024

While the original issue described by @cassidylaidlaw has been resolved in pull/41, @explody 's structural question is still valid.

I'm closing this issue as completed, however I have made a note about considering refactoring postal code out of locality in a future release here. Please see #98 for updates on django-address

from django-address.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.