Comments (7)
I am also seeing duplicate looking address entries in my address table. Not sure if this is the cause or an effect. I see at least 2 more on the same page as well.
from django-address.
Thanks for the report, I'll look in to it first thing this morning.
from django-address.
Hi again John,
Okay, firstly, yep, it's the duplicate addresses that are causing the problem. I've updated the code to prevent the error and use one of the existing duplicates (and prints a verbose warning). Your users should be able to enter addresses that have duplicates now.
I ran a bunch of tests and it looks like the code does prevent duplicates after migrations have been run. This indicates the duplicates were most likely introduced during your initial migration. I'll need to analyse the migration code and figure out where this is happening to prevent it occurring again for other migrations.
In the mean time, I'll write a helper piece of code to assist in removing duplicates, but you'll need to your own hook into the code so we can update any other models you may have that refer to the duplicates. I'll keep you posted.
Cheers,
Luke
from django-address.
Hi Luke,
I'm now using the head on develop and it appears to have fixed this issue.
Two questions:
- Also, any update on that piece of helper code?
- Do you think we'll be on master in the foreseeable future?
thanks!
John
from django-address.
Hi John,
Sorry, I haven't looked at the helper code yet. :( I'll hopefully get some time to take a look over the next week or two.
I've been thinking of splitting the develop branch off into a separate repository. It's diverged quite a lot from the master branch, and I'm not sure I should force users into moving to what is a very different system.
Cheers,
Luke
from django-address.
No problem, I don't think the current (unmerged status) is causing any problems.
What you're suggesting is a major version change with a migration path or a completely separate project with no migration path? My only concern would be creating more independent projects that you are trying to maintain in your limited time, but I can see how it could be less work overall.
from django-address.
Since the underlying issue related to this is handled, closing this. I do see the additional references to the dev
vs master
situation.
from django-address.
Related Issues (20)
- Add end-to-end tests
- Use Docker for example site HOT 2
- Admin does not query google HOT 2
- default Autofield and django 3.2
- Update translation to Django 4 HOT 1
- Nonexistent parent node ('address', '004_auto_20220227_1259') HOT 16
- Include serializers for usage inside rest framework HOT 2
- Error installing version 0.2.7 due to incorrect metadata HOT 1
- Python3.9 integration HOT 2
- Address save via admin saves the primary key into raw column, and additionally creates a bare new object HOT 3
- unique=True HOT 2
- Error when using together with Django autocomplete fields in admin HOT 3
- {{ form.media }} seems to render nothing in Django 4 HOT 2
- Address Form field only populates if full address is provided.
- Fill related models upon Address creation.
- Support for model serializer with django-rest-framework HOT 4
- Add documentation to readthedocs
- Prefer django_countries.fields.CountryField instead of implement address.models.Country
- AddressField on admin site
- Cant select address without `address_street_number`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from django-address.