Git Product home page Git Product logo

Comments (7)

jplehmann avatar jplehmann commented on July 19, 2024

I am also seeing duplicate looking address entries in my address table. Not sure if this is the cause or an effect. I see at least 2 more on the same page as well.

screen shot 2016-02-24 at 8 42 07 am

from django-address.

furious-luke avatar furious-luke commented on July 19, 2024

Thanks for the report, I'll look in to it first thing this morning.

from django-address.

furious-luke avatar furious-luke commented on July 19, 2024

Hi again John,

Okay, firstly, yep, it's the duplicate addresses that are causing the problem. I've updated the code to prevent the error and use one of the existing duplicates (and prints a verbose warning). Your users should be able to enter addresses that have duplicates now.

I ran a bunch of tests and it looks like the code does prevent duplicates after migrations have been run. This indicates the duplicates were most likely introduced during your initial migration. I'll need to analyse the migration code and figure out where this is happening to prevent it occurring again for other migrations.

In the mean time, I'll write a helper piece of code to assist in removing duplicates, but you'll need to your own hook into the code so we can update any other models you may have that refer to the duplicates. I'll keep you posted.

Cheers,
Luke

from django-address.

jplehmann avatar jplehmann commented on July 19, 2024

Hi Luke,

I'm now using the head on develop and it appears to have fixed this issue.

Two questions:

  1. Also, any update on that piece of helper code?
  2. Do you think we'll be on master in the foreseeable future?

thanks!
John

from django-address.

furious-luke avatar furious-luke commented on July 19, 2024

Hi John,

Sorry, I haven't looked at the helper code yet. :( I'll hopefully get some time to take a look over the next week or two.

I've been thinking of splitting the develop branch off into a separate repository. It's diverged quite a lot from the master branch, and I'm not sure I should force users into moving to what is a very different system.

Cheers,
Luke

from django-address.

jplehmann avatar jplehmann commented on July 19, 2024

No problem, I don't think the current (unmerged status) is causing any problems.

What you're suggesting is a major version change with a migration path or a completely separate project with no migration path? My only concern would be creating more independent projects that you are trying to maintain in your limited time, but I can see how it could be less work overall.

from django-address.

banagale avatar banagale commented on July 19, 2024

Since the underlying issue related to this is handled, closing this. I do see the additional references to the dev vs master situation.

from django-address.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.