Instance isn't saved when trying to migrating to 0.2 about django-address HOT 10 CLOSED

Hi John,

Glad to hear you're starting to look at migrating to 0.2!

So, I'm not sure when you checked out the code, but would you mind double checking that you're using the latest commits to the dev branch? I've been making some tweaks lately that may have corrected this issue.

If you still find it's not working I'll set up a test dataset and check that it works from here.

Cheers,
Luke

from django-address.

Hi Luke, my requirements file is pointed at the latest commit in dev as of
this morning:

+git+
https://github.com/furious-luke/django-address@c30e4b4f9a42897c7da1af488e4dfef3d2a5a894

On Wed, Jan 6, 2016 at 8:10 PM, Luke Hodkinson [email protected]
wrote:

Hi John,

Glad to hear you're starting to look at migrating to 0.2!

So, I'm not sure when you checked out the code, but would you mind double
checking that you're using the latest commits to the dev branch? I've
been making some tweaks lately that may have corrected this issue.

If you still find it's not working I'll set up a test dataset and check
that it works from here.

Cheers,
Luke

—
Reply to this email directly or view it on GitHub
#30 (comment)
.

from django-address.

Right you are. I'll set up some test data and see if I can replicate the problem.

from django-address.

Hi again John,

After some digging around (and fixing some other problems I've just noticed), it seems I am unable to replicate your issue. I don't seem to be facing any issues assigning a Component to another Component when neither of them are saved.

What version of Django are you running? And which DBRM are you using?

Cheers,
Luke

from django-address.

It looks like Django 1.8.3 added in a check to throw an error if the foreign-key is unsaved. I'm using Django 1.9 and that error no longer seems to be present.

from django-address.

Am using Django 1.8.2 with Postgresql 9.2.

On Thu, Jan 7, 2016 at 12:13 AM, Luke Hodkinson [email protected]
wrote:

Hi again John,

After some digging around (and fixing some other problems I've just
noticed), it seems I am unable to replicate your issue. I don't seem to be
facing any issues assigning a Component to another Component when neither
of them are saved.

What version of Django are you running? And which DBRM are you using?

Cheers,
Luke

—
Reply to this email directly or view it on GitHub
#30 (comment)
.

from django-address.

Yep, no problems. I know how to disable that Django exception manually, I'll update the code first thing tomorrow and run some tests.

from django-address.

Trying to upgrade to 1.9 but it may be some work for me due to other libraries' issues.

I unmigrated, then got your latest change, then migrated again and still have have the same issue, not that you were advertising those changes would fix anything.

from django-address.

Okay, I've pushed some changes which I hope will fix the issue. I've not actually tested on Django 1.8.2, but I think it should do the job. If not I'll stop being lazy and actually install 1.8.2 and test it myself. :)

from django-address.

Great success, fixed in 5bc3339.

from django-address.